From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8DB3B6366 for ; Fri, 5 Jun 2026 15:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780673740; cv=none; b=bErPumSQ96z+hmlJm0ffkHytXPVDE0mmA79HHph1wBDTHEU72+7EV4Z+hMSO6zhCOByuvQdhhbkbu+FEOiUfUmedupHaN4Za75D0odYVHaTSIvW1B1xa5LEW76n3V+FqbPRRdvWWfh4xXrKQfzHt7U9oDOjpA8A8KbriDymGlPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780673740; c=relaxed/simple; bh=IzQ6VY1/pCSCuW589uWkrY4rVnE4dY+yC+x9fXtuNY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VKxFFooipXPtqIsRp4oWnRtiNqMaBBqZa4eMaet7y0quh1xMMCMW+0Ry1pfpDZGGn3T+cEtCJNU+YgxuC6J/F/b0TYVCYu3+Mzm1n0mUniViKGpuv2GTOiwxDHY4cC/PfqZ3IKg3sQcgCYIOYmwE4Dfsmtr/ARxnUwRXkt1qcB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BbttMqiV; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BbttMqiV" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-842307472d4so719868b3a.0 for ; Fri, 05 Jun 2026 08:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780673734; x=1781278534; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XoDRJzQHz7VdEkd5BqZ67I7g6IeSlqxM9mM4zX/QtD0=; b=BbttMqiViaNA1nIeY58aGXn3fbQ+t4FYPmlDbFGL/urEb4gDpJPX/rioScSxtKDJ4l 2eA+wZaLzUYa8Bje1j3h75g1MDS87chBAUkj0FJVUybNFIsEYK83hRWBKaAha5HezH5d a7AZWpSHkmLJEggzOkdlPJnM6e3XZBNqzHEhKTnje5U1nf5OrVvMj3IyTkfhGLfstP8w K9u3LtBBGVhbvJCRaTrFbBLSV3/bpQ+xR4FObmwizJUWQg2ltk5fsp/NhS1SO4xFMggN P6teWll26tAFJY+kixRUGxlrhh4JVcQ+jiS9St+ftlrG/uDBG8ZyccoCh4hp2QnFCOoI gQiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780673734; x=1781278534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XoDRJzQHz7VdEkd5BqZ67I7g6IeSlqxM9mM4zX/QtD0=; b=aE4MAIpkAkQ04RkhGzrdTQDxbsK2jXxr8I9A3R7HZUlExzvLmMozD9hXZkGBXSW5Id IUaDLs0r4uufuUZ7EY0bxPKb0abiODc9m+/rNW1PtXAtCnh60UFIKPJSdPCsMF47NbgG RGL0EvM3pIrsBSreSSjiay2k+lyXzz38LFlOem/Z8orszNWO5qlTRQuYC62aHvfryOqj JSJ+W1frt0SS7ydHBMyQ9m0dVDwXAVtXsqay4XxOojOmj4uVXHTx/R11Q4K7+EBRayII E3TBBkssxu68HhYp/ThMp38g0fJUs7UzxFfVXdNGhto6fmCmvROdHUcjbrve1Jn3WAOg ILDQ== X-Forwarded-Encrypted: i=1; AFNElJ+LD9L0o1CVfJrVyhhfGDDqNDa7gDZgU9LyD+gyBtKF+zxercNy5LYEcYKJy9o0kcrjUEp0tYY=@vger.kernel.org X-Gm-Message-State: AOJu0YwZ7exWjQITWJ8GTI88LaXNPqCHaHrStaCL1CvcWGE8fI8xJhWD 2bpULBeaYT7Kh+figgx45oRFR451HnKp+RPlAnUGO7Bi7Tsj1/tr+WyU X-Gm-Gg: Acq92OH85tTJw59bT74WatSYGIdLoUZ3Ek6lZmXMoGAeFamS93S64E8OwZSJV1adLXp 6FoIFXm++p8X0uwMGMXTkQI7sv5Z0NAx8dxN65lMyVkpJgFWOihylr1fBoDzM5dEloQ+nE6/4GR ZOI7Al3SvQ00yBlBxCFZTss9ecSHiu8EoOvMqP6UjgUo+/O6syO2tkYJo6S41JuP2i8HtAwjJg+ eFvcdc6hftilMSpEEqELapcSzueB0UVreoAN8nOLVzQucg6d65o4BMxe8VTPfcJcPoag5HfPjmu NSCBCuNDfnR6gguzuG7zR79iRylF94h2Aiv7yk4SAY2N83mrNgjEWb1FKxNZrEOYbhp2mlaHfbM wwbZp2sTttXzW0MPTeE8wOLqASFF0nYSeEcuzeXcsv72TEIEC3HJCxovbBquvGYODzPF7im/yfL 7q+6tKG+H9bi6Gvfw02MTb+jemkOA= X-Received: by 2002:a05:6a20:9383:b0:3a0:b781:4c80 with SMTP id adf61e73a8af0-3b4cccff825mr4945669637.4.1780673734235; Fri, 05 Jun 2026 08:35:34 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:57::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0a4afdsm10022248a12.19.2026.06.05.08.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 08:35:33 -0700 (PDT) Date: Fri, 5 Jun 2026 08:33:04 -0700 From: Stanislav Fomichev To: Bobby Eshleman Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Gerd Hoffmann , Vivek Kasireddy , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kselftest@vger.kernel.org, sdf@fomichev.me, razor@blackwall.org, daniel@iogearbox.net, almasrymina@google.com, matttbe@kernel.org, skhawaja@google.com, dw@davidwei.uk, Bobby Eshleman Subject: Re: [PATCH net-next 1/4] net: devmem: allow rx-buf-size > PAGE_SIZE per dmabuf binding Message-ID: References: <20260603-tcpdm-large-niovs-v1-0-f37a4ac6726c@meta.com> <20260603-tcpdm-large-niovs-v1-1-f37a4ac6726c@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260603-tcpdm-large-niovs-v1-1-f37a4ac6726c@meta.com> On 06/03, Bobby Eshleman wrote: > From: Bobby Eshleman > > Every devmem dmabuf binding today hands the page_pool PAGE_SIZE niovs. > This caps a single RX descriptor at PAGE_SIZE, burning CPU on buffer > churn for large flows. > > Add a bind-time netlink attribute, NETDEV_A_DMABUF_RX_BUF_SIZE, that > lets userspace request a larger niov size. The value must be a power of > two >= PAGE_SIZE. > > Measurements > ------------ > Setup: kperf in devmem RX/TX cuda mode, 4 flows, 64 MB messages, 60s, > dctcp, num-rx-queues=4, dmabuf-rx/tx-size-mb=2048, 10 runs per niov > size, mlx5. > > CPU Util: > > niov net sirq % net idle % app sys % app idle % > ----- ---------------- ---------------- ---------------- ---------------- > 4K 62.38 +/- 8.27 33.40 +/- 7.51 54.15 +/- 10.23 43.67 +/- 10.53 > 16K 58.91 +/- 5.35 35.23 +/- 5.88 41.05 +/- 8.87 56.42 +/- 9.24 > 32K 64.12 +/- 0.68 31.09 +/- 1.48 44.54 +/- 3.51 52.63 +/- 3.65 > 64K 54.69 +/- 5.54 39.67 +/- 5.81 35.47 +/- 3.11 61.97 +/- 3.27 > > RX app sys % drops ~19% from 4K to 64K. > > Throughput: > > niov RX dev Gbps RX flow avg Gbps > ----- ---------------- ----------------- > 4K 300.63 +/- 53.21 75.16 +/- 13.30 > 16K 321.35 +/- 28.20 80.34 +/- 7.05 > 32K 347.63 +/- 2.20 86.91 +/- 0.55 > 64K 332.11 +/- 14.26 83.03 +/- 3.56 > > Throughput seems to increase, but the stdev is pretty wide so could just > be noise. > > kperf support (not yet merged): > https://github.com/facebookexperimental/kperf/commit/8837577f920876bce6986ec18869ac04439ebcd2 > > Signed-off-by: Bobby Eshleman > --- > Documentation/netlink/specs/netdev.yaml | 8 +++++ > include/uapi/linux/netdev.h | 1 + > net/core/devmem.c | 52 +++++++++++++++++++-------------- > net/core/devmem.h | 13 ++++++--- > net/core/netdev-genl-gen.c | 5 ++-- > net/core/netdev-genl.c | 18 ++++++++++-- > tools/include/uapi/linux/netdev.h | 1 + > 7 files changed, 68 insertions(+), 30 deletions(-) > > diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml > index a1f4c5a561e9..063119907983 100644 > --- a/Documentation/netlink/specs/netdev.yaml > +++ b/Documentation/netlink/specs/netdev.yaml > @@ -591,6 +591,13 @@ attribute-sets: > type: u32 > checks: > min: 1 > + - > + name: rx-buf-size > + doc: | > + Size in bytes of each RX buffer the NIC writes into from the bound > + dmabuf. Must be a power of two and >= PAGE_SIZE; defaults to > + PAGE_SIZE. > + type: u32 > > operations: > list: > @@ -805,6 +812,7 @@ operations: > - ifindex > - fd > - queues > + - rx-buf-size > reply: > attributes: > - id > diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h > index 7df1056a35fd..180a4ffffd60 100644 > --- a/include/uapi/linux/netdev.h > +++ b/include/uapi/linux/netdev.h > @@ -217,6 +217,7 @@ enum { > NETDEV_A_DMABUF_QUEUES, > NETDEV_A_DMABUF_FD, > NETDEV_A_DMABUF_ID, > + NETDEV_A_DMABUF_RX_BUF_SIZE, > > __NETDEV_A_DMABUF_MAX, > NETDEV_A_DMABUF_MAX = (__NETDEV_A_DMABUF_MAX - 1) > diff --git a/net/core/devmem.c b/net/core/devmem.c > index 957d6b96216b..5a1c0d7984a8 100644 > --- a/net/core/devmem.c > +++ b/net/core/devmem.c > @@ -46,7 +46,7 @@ static dma_addr_t net_devmem_get_dma_addr(const struct net_iov *niov) > > owner = net_devmem_iov_to_chunk_owner(niov); > return owner->base_dma_addr + > - ((dma_addr_t)net_iov_idx(niov) << PAGE_SHIFT); > + ((dma_addr_t)net_iov_idx(niov) << owner->binding->niov_shift); > } > > static void net_devmem_dmabuf_binding_release(struct percpu_ref *ref) > @@ -93,13 +93,14 @@ net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding) > ssize_t offset; > ssize_t index; > > - dma_addr = gen_pool_alloc_owner(binding->chunk_pool, PAGE_SIZE, > + dma_addr = gen_pool_alloc_owner(binding->chunk_pool, > + 1UL << binding->niov_shift, > (void **)&owner); > if (!dma_addr) > return NULL; > > offset = dma_addr - owner->base_dma_addr; > - index = offset / PAGE_SIZE; > + index = offset >> binding->niov_shift; > niov = &owner->area.niovs[index]; > > niov->desc.pp_magic = 0; > @@ -113,12 +114,13 @@ void net_devmem_free_dmabuf(struct net_iov *niov) > { > struct net_devmem_dmabuf_binding *binding = net_devmem_iov_binding(niov); > unsigned long dma_addr = net_devmem_get_dma_addr(niov); > + size_t niov_size = 1UL << binding->niov_shift; > > if (WARN_ON(!gen_pool_has_addr(binding->chunk_pool, dma_addr, > - PAGE_SIZE))) > + niov_size))) > return; > > - gen_pool_free(binding->chunk_pool, dma_addr, PAGE_SIZE); > + gen_pool_free(binding->chunk_pool, dma_addr, niov_size); > } > > void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding) > @@ -163,6 +165,9 @@ int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx, > u32 xa_idx; > int err; > > + if (binding->niov_shift != PAGE_SHIFT) > + mp_params.rx_page_size = 1U << binding->niov_shift; > + > err = netif_mp_open_rxq(dev, rxq_idx, &mp_params, extack); > if (err) > return err; > @@ -184,14 +189,16 @@ struct net_devmem_dmabuf_binding * > net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > struct device *dma_dev, > enum dma_data_direction direction, > - unsigned int dmabuf_fd, struct netdev_nl_sock *priv, > + unsigned int dmabuf_fd, unsigned int niov_shift, > + struct netdev_nl_sock *priv, > struct netlink_ext_ack *extack) > { > struct net_devmem_dmabuf_binding *binding; > + size_t niov_size = 1UL << niov_shift; > static u32 id_alloc_next; > + unsigned int sg_idx, i; > struct scatterlist *sg; > struct dma_buf *dmabuf; > - unsigned int sg_idx, i; > unsigned long virtual; > int err; > > @@ -213,6 +220,7 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > > binding->dev = dev; > binding->vdev = vdev; > + binding->niov_shift = niov_shift; > xa_init_flags(&binding->bound_rxqs, XA_FLAGS_ALLOC); > > err = percpu_ref_init(&binding->ref, > @@ -248,18 +256,14 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > goto err_unmap; > } > binding->tx_vec = kvmalloc_objs(struct net_iov *, > - dmabuf->size / PAGE_SIZE); > + dmabuf->size >> niov_shift); > if (!binding->tx_vec) { > err = -ENOMEM; > goto err_unmap; > } > } > > - /* For simplicity we expect to make PAGE_SIZE allocations, but the > - * binding can be much more flexible than that. We may be able to > - * allocate MTU sized chunks here. Leave that for future work... > - */ > - binding->chunk_pool = gen_pool_create(PAGE_SHIFT, > + binding->chunk_pool = gen_pool_create(niov_shift, > dev_to_node(&dev->dev)); > if (!binding->chunk_pool) { > err = -ENOMEM; > @@ -273,9 +277,11 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > size_t len = sg_dma_len(sg); > struct net_iov *niov; > > - if (!IS_ALIGNED(len, PAGE_SIZE)) { > + if (!IS_ALIGNED(dma_addr, niov_size) || > + !IS_ALIGNED(len, niov_size)) { > err = -EINVAL; > - NL_SET_ERR_MSG(extack, "dma-buf SG length must be PAGE_SIZE aligned"); > + NL_SET_ERR_MSG(extack, > + "dmabuf sg entry not aligned to niov size"); nit: should we NL_SET_ERR_MSG_FMT here and export chunk len and expected alignment? > goto err_free_chunks; > } > > @@ -288,7 +294,7 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > > owner->area.base_virtual = virtual; > owner->base_dma_addr = dma_addr; > - owner->area.num_niovs = len / PAGE_SIZE; > + owner->area.num_niovs = len >> niov_shift; > owner->binding = binding; > > err = gen_pool_add_owner(binding->chunk_pool, dma_addr, > @@ -313,7 +319,7 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, > page_pool_set_dma_addr_netmem(net_iov_to_netmem(niov), > net_devmem_get_dma_addr(niov)); > if (direction == DMA_TO_DEVICE) > - binding->tx_vec[owner->area.base_virtual / PAGE_SIZE + i] = niov; > + binding->tx_vec[(owner->area.base_virtual >> niov_shift) + i] = niov; > } > > virtual += len; > @@ -430,13 +436,15 @@ struct net_iov * > net_devmem_get_niov_at(struct net_devmem_dmabuf_binding *binding, > size_t virt_addr, size_t *off, size_t *size) > { > + size_t niov_size = 1UL << binding->niov_shift; > + > if (virt_addr >= binding->dmabuf->size) > return NULL; > > - *off = virt_addr % PAGE_SIZE; > - *size = PAGE_SIZE - *off; > + *off = virt_addr & (niov_size - 1); > + *size = niov_size - *off; > > - return binding->tx_vec[virt_addr / PAGE_SIZE]; > + return binding->tx_vec[virt_addr >> binding->niov_shift]; > } > > /*** "Dmabuf devmem memory provider" ***/ > @@ -454,8 +462,8 @@ int mp_dmabuf_devmem_init(struct page_pool *pool) > pool->dma_sync = false; > pool->dma_sync_for_cpu = false; > > - if (pool->p.order != 0) > - return -E2BIG; > + if (pool->p.order != binding->niov_shift - PAGE_SHIFT) > + return -EINVAL; Any specific reason you change E2BIG to EINVAL?