From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0203E3101B0; Mon, 8 Jun 2026 02:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780885343; cv=none; b=EgytoA+uuwEUbmwkioBdK95xpIW4ww5G68LMVZzo0tMeGV8z0/kH9XB3RvDhCbKoBwmC4akcNyI6yyLJCoXeB+rH0dAim0cpiQIGBDtlDib0iSRF8sgpoIg1/69Qg/KxvGR4RcH01303xN5tg1XbxufK+Nt3lrTSxTFLby/j0vY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780885343; c=relaxed/simple; bh=xvOoqco9dwU3X3XFzeo7jF88zraiZQxApGT22ShlaMk=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UscDBt1YySKZAOmjzKb/6tWKD+PRFdSLTE0kNjIUYq/Dik5pPlXWUjynFFMO8mxSoJ5WaeQnA4SusASjHb4KlCOHGZJgshaOb9LmwGfbAZBF2eG+YW2fCdtU2oZGMHLM0VozrxRscA/SgfVTnQSJqQtSsHx1XphYvKU+Shnpnss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=WDJM136l; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="WDJM136l" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6580ElQG936625; Sun, 7 Jun 2026 19:22:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pfpt0220; bh=ETHgFE2mbtIfJYR61afM06NqO 1jiiybK9cK7CYCUqOM=; b=WDJM136lT5yQv8KHmVIWk6r41t64H5mhg6m5G6zb4 8ctmeDbj4xWZ54FBl39yAR1rYDs81lFTyr7rZ6rLwcu++ofB9L1je1+OYeGjWQD3 ux/yy6EaOSXcNbY+xgCRvK9AO70ZqDVC2olikEymglidi4d275QPfAcu9mjrUQ0o vLYnG4BKaYT38Kxa9ncB27jqm1xAnAS+wYo1O1t/hwTyhfVvVButkzmi6cTLKdNX Oexj1tzPjsnUpjRiSsMCeYlubovOBoi594hwv7JRFyPA6vqKn3XFe/kMkR4qm9Ts CJBtwCSmAg8afYpksjLEi1n18vgzCguNh/LBwIlb5IX0g== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4emk2emrfy-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Jun 2026 19:22:13 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Sun, 7 Jun 2026 19:22:11 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend Transport; Sun, 7 Jun 2026 19:22:11 -0700 Received: from rkannoth-OptiPlex-7090 (unknown [10.28.36.165]) by maili.marvell.com (Postfix) with SMTP id 9F9C65B6932; Sun, 7 Jun 2026 19:22:08 -0700 (PDT) Date: Mon, 8 Jun 2026 07:52:07 +0530 From: Ratheesh Kannoth To: , CC: , , , , , , , , Subject: Re: [PATCH v19 net-next 5/9] octeontx2-af: npc: cn20k: add subbank search order control Message-ID: References: <20260605063245.3553861-1-rkannoth@marvell.com> <20260605063245.3553861-6-rkannoth@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260605063245.3553861-6-rkannoth@marvell.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDAxOSBTYWx0ZWRfX4bFZlIzxnQvj kl0n9MS2rXK6FTfzGQ0k2YUeCpLFiqSWK+z0wAnIFY7tMDowI7KoX5wRqYMCkBsfe024rIeegJZ tgWd3qK1vu+1/7EaM1+dqXx8nRO/v6ZamhuuYMSnnMSwUkOp+pxGK0K84Q5qo1qmCna1BamT+Pz yd7ullMgJUxTMxbqsFawHv938mNmGqcLr/G/jm11ptS/iCARwhkkoToLddx7knpYyTG3FeGANpx g7Y26zin8yVOLICDpjDQDqO2VOTEHKHi9WMI5cKtISxfamzS1CykkEAfsiHWCIJKpfwgRKSTGn+ Cq4KmqFhalVxpg3WaPlwFyu5O14H+nRUtLgCZ0DArOjCoaItMxqR1V7OhANg+B/gVErJLhAnJdL CUMFCAxAXjPlckggRT0wYXXmkV6c1Ngi8smqn7e+VjZMFofXzAoP8wHuHhuuQxXRvNJJ6MeBpi3 9euC1dDYKdDelVI09ug== X-Proofpoint-GUID: AQV6HOAJxhKs6yQIZrqDL6gOSoKTxQ4C X-Authority-Analysis: v=2.4 cv=bJUm5v+Z c=1 sm=1 tr=0 ts=6a262755 cx=c_pps a=rEv8fa4AjpPjGxpoe8rlIQ==:117 a=rEv8fa4AjpPjGxpoe8rlIQ==:17 a=kj9zAlcOel0A:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=l0iWHRpgs5sLHlkKQ1IR:22 a=QXcCYyLzdtTjyudCfB6f:22 a=c92rfblmAAAA:8 a=M5GUcnROAAAA:8 a=xf30bXlcfD2pyG46aycA:9 a=CjuIK1q_8ugA:10 a=GvGzcOZaWPEFPQC_NcjD:22 a=OBjm3rFKGHvpk9ecZwUJ:22 a=Oh551-UHZqmTy8JkqTUo:22 X-Proofpoint-ORIG-GUID: AQV6HOAJxhKs6yQIZrqDL6gOSoKTxQ4C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_01,2026-06-05_02,2025-10-01_01 On 2026-06-05 at 12:02:41, Ratheesh Kannoth (rkannoth@marvell.com) wrote: > CN20K NPC MCAM is split into 32 subbanks that are searched in a > predefined order during allocation. Lower-numbered subbanks have > higher priority than higher-numbered ones. > > Add a runtime "srch_order" to control the order in which > subbanks are searched during MCAM allocation. > > Signed-off-by: Ratheesh Kannoth https://sashiko.dev/#/patchset/20260605063245.3553861-1-rkannoth%40marvell.com says > @@ -1566,13 +1569,15 @@ int rvu_mbox_handler_nix_lf_alloc(struct rvu *rvu, >> >> /* Alloc NIX RQ HW context memory and config the base */ >> hwctx_size = 1UL << ((ctx_cfg >> 4) & 0xF); >> - err = qmem_alloc(rvu->dev, &pfvf->rq_ctx, req->rq_cnt, hwctx_size); >> - if (err) >> + rc = qmem_alloc(rvu->dev, &pfvf->rq_ctx, req->rq_cnt, hwctx_size); >> + if (rc) >> goto free_mem; >> >> pfvf->rq_bmap = kcalloc(req->rq_cnt, sizeof(long), GFP_KERNEL); >> - if (!pfvf->rq_bmap) >> + if (!pfvf->rq_bmap) { >> + rc = -ENOMEM; >> goto free_mem; >> + } >This is a pre-existing issue, but I wanted to ask about what happens if a >VF or PF repeatedly sends the NIX_LF_ALLOC mailbox message without an >intervening NIX_LF_FREE message. Pre-existing issue, will address as a seperate patch after this series is merged.