From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAEAE2E7F0A for ; Mon, 8 Jun 2026 09:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780911146; cv=none; b=n6Axp49UyZJ+ryNQBjf8HZWCvfLxlyTnKuudKCuDjTA8ttRLXsMfOtVz++kLUIvA34GCWCLwXgfAMLYkurfq/0MI3qxBYNU/3qb0xd3kXZ1zzBdV4ML9ismVfO0cvyTydwIM+iYEI6SyRotplmwqlOXj+sYva/yYAx7ysz5opeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780911146; c=relaxed/simple; bh=rrtvF0lNcj+pHRtfwXDY3phiLJ219l2m72vOnALNy8g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d/gFRUJw0OUjaEtKpN9GL8BYTydoXFHcLoltqkqx9EJxy1cGf2BURyV1rzWHoMDXHs5Se/cPIkctj9s5aHfbFZ1Z1dlr/uw8MEAFH6XSZBl0AKsNH0uaNelSzxwqgxehi6exejpA1vCWnL7e4gyiY5APyqdcbURzfCmr2ec5H1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wx0nR9mo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wx0nR9mo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8C351F00893; Mon, 8 Jun 2026 09:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780911145; bh=ber3utn/8EUmJVjFuWAwn9vEtzDxpWGplyIMDowu99g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Wx0nR9mok/6CM2+NSHU3FRGlv4mFmxhM9+nz/9D9zYxNnja3GH/7MC2DD90ujMk2i gSBpBUixI1ubPXnguTHRsGKMQ6gP5MJFR14oM77wXK6EKUsiJIwOlvWxHvhWvGXtdX 6ttNKVy7kDYbCO4MKiyKGM2NTYDvXKB8d/KXMaNNZpZXAEFFTsA3gDcyhtc9uvhFDG F7imx4OXYr+skEUgOfBGkSLZGC/nZKciFw28FDIjFgGk4fgo0pyVqUPDSzIa33FBrW mLt8vQKwtKSNoFF8tcLbL4CqwWE8vPP2QZV6DYG61HzUFftORZiWuwhIjqriCPlCOh aJ9JWlkShUhhg== Date: Mon, 8 Jun 2026 11:32:23 +0200 From: Lorenzo Bianconi To: Andrew Lunn Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Madhur Agrawal Subject: Re: [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback Message-ID: References: <20260607-airoha-ethtool-priv_flags-v2-1-742c7aa1e182@kernel.org> <33c3a87d-ad97-4f6a-8f76-ebab80c496ac@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="adOSsypNp6f03yZM" Content-Disposition: inline In-Reply-To: --adOSsypNp6f03yZM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Sun, Jun 07, 2026 at 08:07:37PM +0200, Lorenzo Bianconi wrote: > > > > When a GDM3/GDM4 port is set to WAN mode, enable GDM2 loopback to > > > > support hardware QoS. Conversely, when switching back to LAN mode, > > > > disable the GDM2 loopback and restore the default forwarding > > > > configuration. > > >=20 > > > Why not just use the presence of an off loadable qdisc as the > > > indicator to change mode? > >=20 > > Hi Andrew, > >=20 > > Interesting, can you please provide more details about you mean? >=20 > You say you need it to be in loopback mode in order to support > hardware QoS. You configure QoS by using a qdisc, and something like > mqprio, tcf etc. So when the user configures QoS, you can see if the > hardware supports the request QoS. If so, swap to loopback mode and > offload the QoS function to the hardware. If the hardware does not > support the requested QoS, leave it in software and keep with LAN > mode. ack thx, nice idea. I will rework this patch in order to rely on tc to configure GDM3/GDM4 ports in LAN/WAN mode. Regards, Lorenzo >=20 > Andrew --adOSsypNp6f03yZM Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaiaMJwAKCRA6cBh0uS2t rK2bAPwIvDBSx3qJGo2xGvPkpy2z4KzEamk7juLxscsrz/+wtQEAl3TTMKLxFV09 y3YJwHEv243V0HLZH15bEMGGSDKoWws= =rM/X -----END PGP SIGNATURE----- --adOSsypNp6f03yZM--