From: Sabrina Dubroca <sd@queasysnail.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Geliang Tang <geliang@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Atul Gupta <atul.gupta@chelsio.com>,
Geliang Tang <tanggeliang@kylinos.cn>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH net] tls: restore sk_prot before calling original destructor
Date: Tue, 9 Jun 2026 14:12:58 +0200 [thread overview]
Message-ID: <aigDShl67-mqMs2S@krikkit> (raw)
In-Reply-To: <20260608200254.3be56aa7@kernel.org>
2026-06-08, 20:02:54 -0700, Jakub Kicinski wrote:
> On Mon, 8 Jun 2026 10:28:45 +0200 Sabrina Dubroca wrote:
> > 2026-06-05, 20:57:07 +0800, Geliang Tang wrote:
> > > From: Geliang Tang <tanggeliang@kylinos.cn>
> > >
> > > When a TLS socket is offloaded to a TOE device, tls_toe_bypass() replaces
> >
> > Or maybe it's time to simply drop tls_toe? There's only one driver
> > that uses it (chelsio/chtls), and it hasn't been touched by someone at
> > chelsio since 2021 (2355a6773a2c [1]). Since then, there have been a
> > few fixes by people who I doubt are actually using this (Eric, Dan
> > Carpenter), everything else is treewide/refactoring patches.
>
> Yup, tls_toe is unsalvageable. Sabrina, could you float a net-next
> patch to nuke it?
Good, I'm on it. I'm also removing a bunch of EXPORT_SYMBOL* that are
no longer used (and should never have been used outside of net/ipv6,
but well).
--
Sabrina
prev parent reply other threads:[~2026-06-09 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 12:57 [PATCH net] tls: restore sk_prot before calling original destructor Geliang Tang
2026-06-08 3:24 ` Geliang Tang
2026-06-08 8:28 ` Sabrina Dubroca
2026-06-09 3:02 ` Jakub Kicinski
2026-06-09 12:12 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aigDShl67-mqMs2S@krikkit \
--to=sd@queasysnail.net \
--cc=atul.gupta@chelsio.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tanggeliang@kylinos.cn \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox