From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
dw@davidwei.uk, daniel@iogearbox.net, razor@blackwall.org,
sdf@fomichev.me, dtatulea@nvidia.com, bobbyeshleman@meta.com
Subject: Re: [PATCH net-next 3/4] netdev: avoid skipping objects on race with device disappearance
Date: Tue, 9 Jun 2026 15:04:57 -0700 [thread overview]
Message-ID: <aiiOCRpmdFcOf/yJ@devvm29614.prn0.facebook.com> (raw)
In-Reply-To: <20260609141914.2957de35@kernel.org>
On Tue, Jun 09, 2026 at 02:19:14PM -0700, Jakub Kicinski wrote:
> On Tue, 9 Jun 2026 13:15:05 -0700 Bobby Eshleman wrote:
> > I just noticed we handle this differently in rtnetlink with
> > cb->seq/dev_base_seq/nl_dump_check_consistent(), but it seems like
> > netdev-genl.c intentionally does not use NLM_F_DUMP_INTR?
>
> Intentionally is a strong word, but yes, it's "known".
>
> My mental model is that DUMP_INTR is required when we are dumping
> unordered lists. In those cases we just count "how many objects
> were already dumped", so if we dumped 4 objects then object #1 is
> removed the dump will resume from object which was previously #6
> thinking that it's #5 and #5 will never be dumped.
>
> In netdev objects have ordered IDs, we don't count.
>
> But in theory we probably maybe should also indicate consistency.
> Nobody seems to care in practice.
gotcha, thanks for the clarification.
-Bobby
next prev parent reply other threads:[~2026-06-09 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 19:08 [PATCH net-next 0/4] netdev: address a handful of nit picks Jakub Kicinski
2026-06-09 19:08 ` [PATCH net-next 1/4] netdev: check for nla_put_u32() failures Jakub Kicinski
2026-06-09 19:24 ` Bobby Eshleman
2026-06-09 19:52 ` Daniel Borkmann
2026-06-09 22:05 ` Jakub Kicinski
2026-06-09 19:56 ` Joe Damato
2026-06-09 19:08 ` [PATCH net-next 2/4] netdev: correct error code in netdev_nl_queue_fill_lease() Jakub Kicinski
2026-06-09 19:16 ` Bobby Eshleman
2026-06-09 19:48 ` Daniel Borkmann
2026-06-09 19:57 ` Joe Damato
2026-06-09 19:08 ` [PATCH net-next 3/4] netdev: avoid skipping objects on race with device disappearance Jakub Kicinski
2026-06-09 19:48 ` Daniel Borkmann
2026-06-09 19:59 ` Bobby Eshleman
2026-06-09 20:15 ` Bobby Eshleman
2026-06-09 21:19 ` Jakub Kicinski
2026-06-09 22:04 ` Bobby Eshleman [this message]
2026-06-09 19:08 ` [PATCH net-next 4/4] netdev: don't use dev->flags for IFF_UP Jakub Kicinski
2026-06-09 19:49 ` Daniel Borkmann
2026-06-09 19:54 ` Joe Damato
2026-06-09 20:00 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiiOCRpmdFcOf/yJ@devvm29614.prn0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox