From: Felix Maurer <fmaurer@redhat.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kexin Sun <kexinsun@smail.nju.edu.cn>,
Yury Norov <ynorov@nvidia.com>,
Quan Sun <2022090917019@std.uestc.edu.cn>,
Luka Gejak <luka.gejak@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hsr: simplify fill_last_seq_nrs()
Date: Thu, 11 Jun 2026 10:45:42 +0200 [thread overview]
Message-ID: <aip1tjdLIUXre9e1@thinkpad> (raw)
In-Reply-To: <20260609171545.1051322-1-ynorov@nvidia.com>
On Tue, Jun 09, 2026 at 01:15:44PM -0400, Yury Norov wrote:
> The function checks the HSR_PT_SLAVE_A and HSR_PT_SLAVE_B bitmaps
> for emptiness right before calling find_last_bit().
>
> This pass may be avoided, because if the bitmap is empty, the
> find_last_bit() returns >= HSR_SEQ_BLOCK_SIZE
>
> Signed-off-by: Yury Norov <ynorov@nvidia.com>
Reviewed-by: Felix Maurer <fmaurer@redhat.com>
Looks good to me, thank you!
prev parent reply other threads:[~2026-06-11 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 17:15 [PATCH] net: hsr: simplify fill_last_seq_nrs() Yury Norov
2026-06-11 8:45 ` Felix Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aip1tjdLIUXre9e1@thinkpad \
--to=fmaurer@redhat.com \
--cc=2022090917019@std.uestc.edu.cn \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kexinsun@smail.nju.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox