From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E97283FDD for ; Fri, 12 Jun 2026 14:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781275894; cv=none; b=OWGZx/nQ7PcmeGD7dZVDCMwHqg09oZfqCQGvhxaGa992P7E82G2Cm4wzYLihjcZu6tJJJEPfUq5wgCKzRGMMRIXFppUDpRp/G5Ec5gTRZGJvzOVVKE7ZsqY8a3GKGAUHCBZWNrJKJyYungyY1dbr6uH0F1WxAP16vRJl4whFVA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781275894; c=relaxed/simple; bh=7oTdwQB7busn3pIYd7uITFnQgXBQs1X1Bba/eQqqVE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PKpsxyS/NKsHG9hP+ZthF4gNyEegjJsGrhy7cOvCMevCrY5yKXinAx8bB5bWM58T0Twk1LrU3KluJZcnkKl33RX9DMEXGlJP9caZmwm6HFdgDqdlEfu91n6FYenkzv7eMdS3+J6tjT0HKiw2maFaG29ChgKrr00WXRwX9b54KbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M3WOkHFX; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M3WOkHFX" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36b9ec98144so800199a91.1 for ; Fri, 12 Jun 2026 07:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781275893; x=1781880693; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vFB+L8FiAJWrQfjsmsxH8l7zj4U3yueBuDW7xXAiJHQ=; b=M3WOkHFXvlj8EbFk2lzl8R33lJj6caKn5G738v1XG0tOiZATPSxR63HjY3miXO6nkV OUY5CeT26RFLOpbYwmNyLinnIBgL4RIne6x0xft9OpDAQglSidpAr6hsIWgzVXWMyro5 wHmAcZowI8bngsisSPRzO/Hcu7h9tCy4f1YctoqosM8G1Nq8YNvpGqqNxZNqcOzzwG7J JoF40G61BeIYZTGsDfhdWi4LgxQC9Mb9jYcckTbwoNFcxl/DSDRIN42SzpgdApUe603D ignxJEQFLXGAZZAZNtBgpz9b85jXHaREKgjP3QHVl1PnR0P1Q2UZwP44nUVDosNouhZN KliQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781275893; x=1781880693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vFB+L8FiAJWrQfjsmsxH8l7zj4U3yueBuDW7xXAiJHQ=; b=HGZACGpeB7Hww0K/n+65OCgXcYyMM0ORB0ablAtEDl/S2Iqa+2JdfJE/3E58Y9jMQg rycu8rlbS5y83LvIqHIFNWCNDRbQ32KQGuvdSql652Xyj719+TSU4HMT2W4GBfmSWJmv G9cwj1m8TCYZywKt8hxiF/cBF/FJglmQzcczrrTXLaB2BDrAT0FyPrpuqiNWlLDiqkem 5IgOuv6ZXfUEB69R0YNI5Ft6MTedAP72ZSdaJOXCUuiZ0sZVibhGyjcOtbhwyWiddwiW 8RadnHrUGSHs0VU+p5NwmizzDdQyo3HEbXKkT54oXPkhO2so9NvkSuvtgqC1SjoPRzv7 2IIg== X-Gm-Message-State: AOJu0YyUalzJypt8eVye/cINMIYb4NqpMzO9y3LecJ7Ayds6siZN9pWv SQEPo1hphigysxI+QaILnyGX8TZ71Ai49vOUI0yT5Xgo0130AnlkGNty X-Gm-Gg: Acq92OFYNP6UMhg6mwd4UEXy0GAM9Yb9qDuhb2zbGorVwCbXCF5BG1JAQcF79Bh3ZlG SZGUDgvDz/wlTIL6azJPMfIgaM6d95fF2jwi6HKV4Cd9/i4sxXRRpVCjmFW+Hx6Ya3Cm40LV3PU cFjJZNHUUb7D6/CoKi0782zg77GX1e3DG3v8lwiTcxVmQOAblvEdLtx2XsjAEOUHqZyXkiKx12f AZlAKaTbDJzUE04HVVnSaHlpJjaCvzN7R03pcd4xrsFWh+7Jg7/FX5Ka6f92leIzQqgURS015LL jsaHU7wwM1vBdBVYER8dTSbOAqhtb6cn8Uf8Ing+vCO7ETSkhni9XO2F0qfrli9oeXJu9u5veSI 8F+AbsWqanyLUIxqCPCLcItrxMACEt8ZoI7Dke1MI9Mi5o9BagD8zcBZiZCRMeQ8Xr2LJdTxHyk sfBNb7H5S2kSufbkH028sjodL/5uyRjDZIIVMx7W7mNkAa X-Received: by 2002:a17:90b:4d08:b0:368:b01c:85a0 with SMTP id 98e67ed59e1d1-37a035ed628mr3288310a91.14.1781275893159; Fri, 12 Jun 2026 07:51:33 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:ff:53::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a20dbd301sm2453885a91.10.2026.06.12.07.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 07:51:32 -0700 (PDT) Date: Fri, 12 Jun 2026 07:51:31 -0700 From: Bobby Eshleman To: Raf Dickson Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev, pabeni@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com, bcm-kernel-feedback-list@broadcom.com, leonardi@redhat.com, horms@kernel.org, edumazet@google.com, kuba@kernel.org Subject: Re: [PATCH net-next v3 3/4] vsock: fold sk_acceptq_added() into vsock_enqueue_accept() Message-ID: References: <20260612045216.105796-1-rafdog35@gmail.com> <20260612045216.105796-4-rafdog35@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612045216.105796-4-rafdog35@gmail.com> On Fri, Jun 12, 2026 at 04:52:15AM +0000, Raf Dickson wrote: > virtio and hyperv call sk_acceptq_added() immediately before > vsock_enqueue_accept(). Move the call into vsock_enqueue_accept() > itself so callers cannot forget it and the accounting is consistent. > > Suggested-by: Paolo Abeni > Suggested-by: Stefano Garzarella > Signed-off-by: Raf Dickson > --- > net/vmw_vsock/af_vsock.c | 1 + > net/vmw_vsock/hyperv_transport.c | 1 - > net/vmw_vsock/virtio_transport_common.c | 1 - > 3 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index 6cfa89b6f3..24916dd4e9 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -518,6 +518,7 @@ void vsock_enqueue_accept(struct sock *listener, struct sock *connected) > sock_hold(connected); > sock_hold(listener); > list_add_tail(&vconnected->accept_queue, &vlistener->accept_queue); > + sk_acceptq_added(listener); > } > EXPORT_SYMBOL_GPL(vsock_enqueue_accept); > > diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c > index b3394946b2..0de8148877 100644 > --- a/net/vmw_vsock/hyperv_transport.c > +++ b/net/vmw_vsock/hyperv_transport.c > @@ -410,7 +410,6 @@ static void hvs_open_connection(struct vmbus_channel *chan) > > if (conn_from_host) { > new->sk_state = TCP_ESTABLISHED; > - sk_acceptq_added(sk); > > hvs_new->vm_srv_id = *if_type; > hvs_new->host_srv_id = *if_instance; > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index b10666937c..4a39d48db9 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -1582,7 +1582,6 @@ virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb, > return ret; > } > > - sk_acceptq_added(sk); > if (virtio_transport_space_update(child, skb)) > child->sk_write_space(child); > > -- > 2.54.0 > Reviewed-by: Bobby Eshleman