Re: [PATCH net-next] eth: ionic: delete the incorrect link_down_count reporting

[Breno Leitao <leitao@debian.org>]

On Mon, Jun 15, 2026 at 10:01:53AM -0700, Jakub Kicinski wrote:
> The definition of the statistic is quite clear,
> struct ethtool_link_ext_stats says:
> 
>    This statistic counts when PHY _actually_ went down, or lost link.
> 
> Reportedly this is not how the device-counted stat on ionic behaves.
> The goal is to detect flapping links, due to bad cabling.
> ionic reportedly uses this for some firmware stat of how many times
> the traffic was stopped. This is _not_ what should be reported here.
> 
> Link: https://lore.kernel.org/20260610061830.51037-1-eric.joyner@amd.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Breno Leitao <leitao@debian.org>

CC: brett.creeley@amd.com
> CC: eric.joyner@amd.com
> CC: leitao@debian.org
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 78a802eb159f..f7dcfe3d032d 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -111,15 +111,6 @@ static void ionic_get_regs(struct net_device *netdev, struct ethtool_regs *regs,
>  	memcpy_fromio(p + offset, idev->dev_cmd_regs->words, size);
>  }
>  
> -static void ionic_get_link_ext_stats(struct net_device *netdev,
> -				     struct ethtool_link_ext_stats *stats)
> -{
> -	struct ionic_lif *lif = netdev_priv(netdev);
> -
> -	if (lif->ionic->pdev->is_physfn)
> -		stats->link_down_events = lif->link_down_count;

It seems this is the only place where link_down_count is read. Maybe you
want to kill it as well?