From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b1-smtp.messagingengine.com (fhigh-b1-smtp.messagingengine.com [202.12.124.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425072D4B68; Tue, 23 Jun 2026 09:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205859; cv=none; b=VgIr4OlKwKtKdAoEnJkVgPZmJnVJmRnA3wbduTcZQg0blRUSFSuqfrxxR9FfwV7ngJYJLmZTZfyrW4SFVgb2RgblcM1vUnJfSz7R6efvkcUnPANFZjUOtDgDDDfZH8HstMwZFDlv/VSSxCvE3YjVK357i1LsF+HN3bPxHwLyjoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205859; c=relaxed/simple; bh=H0ejhMob9U1Tp7NLyQih5D7xrwz4zP/ui9ghCzP4aqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JeX5mXjPAXSY7L4TstosWWwRurolLaliHwGeZGoYYLbgvo0ZEz6EQtmMPJC15IVGTqpJfeCECcqJMMx9NLR/TQHMGlbsjCetRFv1ukgdxofb3v7SdnPVBPSEzG0Nf6okfoYVUatvnln5T5ku/8x6V4y3qk5yYKLdNUiHUo1ZTy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=beFqV/F7; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=VTsXWTFi; arc=none smtp.client-ip=202.12.124.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="beFqV/F7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VTsXWTFi" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 165347A015F; Tue, 23 Jun 2026 05:10:55 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 23 Jun 2026 05:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1782205854; x= 1782292254; bh=8hZD5mizY6mE9lDCe600zLjaG96JwIduRGgsYhIAe9I=; b=b eFqV/F7UtNB0TBq0IIZZGfPqfFTBd0IYWOHhLqFmk8Xiqss3EYR90wSwDi/v0GYR m/37H3TjWdnOyJcAxnxnG96iiRQVkMg8i8jkuIufAzObUIUuzVRM1SF/LQuQKc0j F9JH3wOplE1rNStXLwqwBKJuF4kxnwcgjjxn7J7QIvu/5T/Rca0NciCs4Prz1MfW 5fdA1BA+V0SIVS9kBrAMQTSaKHnWQ8RvM4ZnJuBXSyZ/Em6eABk3xQxfwhcjYWGu UttFFyabF62zRmHXylJCzqho67HRZYtM1tB10/MpGnShn+oBavQzXILUEjRDqkE5 SgVnyNxS8dQvwKBIJNcOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782205854; x=1782292254; bh=8hZD5mizY6mE9lDCe600zLjaG96JwIduRGg sYhIAe9I=; b=VTsXWTFiZo/w2/i5o4DbnDqkLyw2vCn9mAfNRU/UkZGJzrEO+xc uy10sWJenOnFD8fP5uBYaweuxOi5Vf54CuxWsAO+8TolYZCJEIkbJE2gZwtzXK88 yHqKk/TFaKFJJTuYD3/eyYJ/OXXiWgED2j1ADcYIGgfeUOXc45rqPIiId3IfnOoX 8R2EC5cJXKFC44N5SPLRisj7rE3o+WqKH/5dYUqghycwDVk8pw3aFG/CmfABrAuz r3GrFAjH7D/6NJ//ApyWbVdBvwYxbyMJjxyf10n7MGHRwoAaAtpwTvV+28KyAPHF 36BbpJ1i5tbrSDtXpSDCbBcexI9uKjO7FPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEZ26e5DWSZZNJ6NO2CAGw1Wd8AuwmZtVtuY9zTCrJXg2jF63KkKQWmSfegBPLJpH /0KzGFi5gcfsMWGJefzPH6JR8um+ccoGk2BdPu+9TADe/Z62pgCUNAWsk4s7Gw482gKDd4 bQtzq1zdT79L0U2SJ9zzIeOPdnhNpVOUR622rzOiPb2ZaVu9y+0V/8T99l705kcGvMbJOG YeXzfqG03OCM0ylXMnMIGQBJBIoKH40Z0eZZzJPkRaGH6ehtES+bqyy3/TndlCYUQKXo2Z Fn7zf/mTmKENN/1l6gRxCOKf5/bkWMAAu4KpaDkDDsQNbN+NZlVYrwTawrztbL2Z0/KuD2 m5gttXcaW79O+igZDGeviVmBTlH+7syG/XPCDiMi/nZWEhyIUE92ozYxDykmXJDQyA1Mri 4ZpELle3+F43/q5Omj4/q7XINXaDiJN3+VnCMLdHGELWHrqkb6HOLz1gZ8R5xl8ivaV5r7 PIlDcGk3Uk7NeZ9msvaAPxIAkLH1O8vJoOZyT1bnJT3VvVhNIJDppkLffzkTQZQI91wtK+ Eb8fyyfJnEcHfreRIb0/NCJcSKwSmdTNdK16xxf+Y95EnIqJijmQFXZzdTlqCnIrhg4p4x ZCUnGuZN2fboAqajHBVfh19M4dDqrH0PvH6bcL7y2WXZPoFbKIMVTk1H+BBA X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Jun 2026 05:10:54 -0400 (EDT) Date: Tue, 23 Jun 2026 11:10:51 +0200 From: Sabrina Dubroca To: Arnd Bergmann Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arnd Bergmann , Daniel Zahka , Rahul Rameshbabu , Raed Salem , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net] eth: mlx5: fix macsec dependency Message-ID: References: <20260622124229.2444502-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260622124229.2444502-1-arnd@kernel.org> 2026-06-22, 14:41:07 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Configurations with mlx5 built-in but macsec=m fail to link: > > x86_64-linux-ld: drivers/infiniband/hw/mlx5/macsec.o: in function `mlx5r_add_gid_macsec_operations': > macsec.c:(.text+0x77d): undefined reference to `macsec_netdev_is_offloaded' > x86_64-linux-ld: drivers/infiniband/hw/mlx5/macsec.o: in function `mlx5r_del_gid_macsec_operations': > macsec.c:(.text+0xe81): undefined reference to `macsec_netdev_is_offloaded' > > Fix the dependency so this configuration cannot happen. > > Signed-off-by: Arnd Bergmann Reviewed-by: Sabrina Dubroca > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ... > @@ -144,7 +144,7 @@ config MLX5_CORE_IPOIB > config MLX5_MACSEC > bool "Connect-X support for MACSec offload" > depends on MLX5_CORE_EN > - depends on MACSEC > + depends on MACSEC=y || MACSEC=MLX5_CORE I'd never seen this 'configA=configB' syntax, cool. -- Sabrina