From: Steffen Klassert <steffen.klassert@secunet.com>
To: Qianyu Luo <qianyuluo3@gmail.com>
Cc: Eyal Birger <eyal.birger@gmail.com>, Ren Wei <n05ec@lzu.edu.cn>,
<netdev@vger.kernel.org>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <yuantan098@gmail.com>, <bird@lzu.edu.cn>
Subject: Re: [PATCH 1/1] xfrm: nat_keepalive: avoid double free on send error
Date: Wed, 24 Jun 2026 13:49:50 +0200 [thread overview]
Message-ID: <ajvEXryefFCo5B6Q@secunet.com> (raw)
In-Reply-To: <CAPOno=q0NxA_LOJ3QaM9Jgk1oM4ZQiW9igipGfxV7+yGvjr+0g@mail.gmail.com>
On Fri, Jun 19, 2026 at 05:06:40PM +0800, Qianyu Luo wrote:
> On Fri, Jun 19, 2026 at 1:21 AM Eyal Birger <eyal.birger@gmail.com> wrote:
> >
> > On Thu, Jun 18, 2026 at 9:36 AM Ren Wei <n05ec@lzu.edu.cn> wrote:
> > >
> > > From: Qianyu Luo <qianyuluo3@gmail.com>
> > >
> > > skb_dst_set(skb, &rt->dst);
> > >
> > > @@ -100,6 +102,7 @@ static int nat_keepalive_send_ipv6(struct sk_buff *skb,
> > > sock_net_set(sk, net);
> > > dst = ip6_dst_lookup_flow(net, sk, &fl6, NULL);
> > > if (IS_ERR(dst)) {
> > > + kfree_skb(skb);
> > > local_unlock_nested_bh(&nat_keepalive_sk_ipv6.bh_lock);
> >
> > Any reason to do the kfree under lock?
> >
>
> Thank you for your reply! I did this without particular reason.
> Just to keep the pre-handoff cleanup in the same error path.
> kfree_skb() does not need the bh lock there, so I can move it after the
> unlock in v2 if you need!
Then move it after the unlock to make it clear it is not needed.
prev parent reply other threads:[~2026-06-24 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1781788385.git.qianyuluo3@gmail.com>
2026-06-18 16:36 ` [PATCH 1/1] xfrm: nat_keepalive: avoid double free on send error Ren Wei
2026-06-18 17:21 ` Eyal Birger
2026-06-19 9:06 ` Qianyu Luo
2026-06-24 11:49 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajvEXryefFCo5B6Q@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=bird@lzu.edu.cn \
--cc=davem@davemloft.net \
--cc=eyal.birger@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=qianyuluo3@gmail.com \
--cc=yuantan098@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox