From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A4E3BBFCC; Mon, 29 Jun 2026 16:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782750108; cv=none; b=Z+sjVpG2aS8Ml3DGfzl7A9fjwLFaRLRGcTYZS5EXyaFdyFh1WXidvSh75Fz1O7RXuRlJke+bdXZy1ryyffJBnfhlwU6YVE9FrmdZFgjBGriL29rE5iAxS/KIZzq0hLxqROXkDuxPr565Scp9ZgoU89K4kQUqxatLBZd7COzwVew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782750108; c=relaxed/simple; bh=NFSMtVuoxLsda44tJKXSv/IYfieoOuyAy+SzWiTGH00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=foXViyWwgidm9hoojvyLNRgMsRzfqOArVbrFQ9HPZbds3BGHI/eGh2I32Qoh9MmWcsO6znDUoRixUrKkxDCNhy23wg7Yj79Z5uXkmQpK87KBCQSyU6TuDxOX3B1kdFpuBtE/HRXtW7dU/IXrt6qZZMWXAbdjVO/mCkJR5rjPHus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SFgg2Qvo; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SFgg2Qvo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782750107; x=1814286107; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NFSMtVuoxLsda44tJKXSv/IYfieoOuyAy+SzWiTGH00=; b=SFgg2Qvonqj8YyAz02Rzoab9VLsyMuk1b2S6GRXzz911VFwK8AOpYQvD gh2NroGboBlOxZxq8ppnrBdmpC3JcV6dGj6ED5gKhkiNZ4kZq0wq0uGbr a3VmAVA5Kc7j8cyv187xM1NfyHX3Aw/6jKgNejMIHBGim9z0LPjAmbRNv /KwjamNzJXqUmKEMFNl1a/e9hN7dype5qHlqx+cd5FPWBmk1oBx2Zrsty Sip63u3gUmIQTLdQwtsvMIwThfeepxeXuej0SWoFnAdkvlblsnuyEszIp g2qHFCbyXLDZ8YYEjAv8nz914j2QuSxDBVNEKCpAfj1IdQ9FIrD35Ckp2 A==; X-CSE-ConnectionGUID: 8i5aSoTjT/OirOQF3Es8rA== X-CSE-MsgGUID: dj77uQ48SyqEHl8D2MbtPQ== X-IronPort-AV: E=McAfee;i="6800,10657,11832"; a="83644931" X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="83644931" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 09:21:46 -0700 X-CSE-ConnectionGUID: FxugsHAHT4+THTJwauLSzw== X-CSE-MsgGUID: nJKI5ILbSS+sjP319WFTsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="290124520" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.207]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 09:21:33 -0700 Date: Mon, 29 Jun 2026 19:21:10 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt , brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v2 19/19] driver core: platform: count references to all kinds of firmware nodes Message-ID: References: <20260629-pdev-fwnode-ref-v2-0-8abe2513f96e@oss.qualcomm.com> <20260629-pdev-fwnode-ref-v2-19-8abe2513f96e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260629-pdev-fwnode-ref-v2-19-8abe2513f96e@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 29, 2026 at 11:12:42AM +0200, Bartosz Golaszewski wrote: > When using platform_device_register_full(), we currently only increase > the reference count of the OF node associated with a platform device. We > symmetrically decrease it in platform_device_release(). With all users in > tree now converted to using provided platform device helpers for > assigning OF and firmware nodes, we can now switch to counting references > of all kinds of firmware nodes. Yep, that's the expected result, thanks! ... > void platform_device_set_fwnode(struct platform_device *pdev, > struct fwnode_handle *fwnode) > { > - if (is_of_node(fwnode)) > - platform_device_set_of_node(pdev, to_of_node(fwnode)); > - else > - pdev->dev.fwnode = fwnode; > + fwnode_handle_put(pdev->dev.fwnode); > + pdev->dev.fwnode = fwnode_handle_get(fwnode); > + pdev->dev.of_node = to_of_node(fwnode); device_set_node(&pdev->dev, fwnode_handle_get(fwnode)); > } ... > pdev->dev.parent = pdevinfo->parent; > - pdev->dev.fwnode = pdevinfo->fwnode; > - pdev->dev.of_node = of_node_get(to_of_node(pdev->dev.fwnode)); > + pdev->dev.fwnode = fwnode_handle_get(pdevinfo->fwnode); > + pdev->dev.of_node = to_of_node(pdev->dev.fwnode); See above. ... With them being addressed, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko