From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BAE840D589 for ; Wed, 1 Jul 2026 00:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782864463; cv=none; b=d6xF/H+cPGVfm5C7+tMYGtVgxy2gTJ3nU0CZZYEu8r3JbTPZPgY8SxJ/HnpgHtU4GZIQVXZQxKFPDKfrlpKKnlDaN6WPUwzoLhgfghD2E6z6B2fBaEWnV0iSUGnnwUuorG+nTYUrjXFYwKxYI/eXnryjWDCBn94ezZ0RXUHtlHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782864463; c=relaxed/simple; bh=lC+k+6mNle6sj5AuGdZt4d9WTpneeUI+q286W11Koso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hr+6bGHyecTCiHJz8GGvIQYMwgJ1AzBksxEACVWGn4aLA+Udo5TsEBSos7uj1t+EzefilT4MKoelapXDJeQ1lQRISbvTwDA70tY4EPP5HbBzlzlc7/gJI5ljBqYL0DF5bZ91x24ig8kmMG+T12NuDxewRi07whdecvEb6Z1us5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OGxc+NpG; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OGxc+NpG" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36b9d265355so62649a91.2 for ; Tue, 30 Jun 2026 17:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782864461; x=1783469261; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NRsFNTp0mbWr+vlnr7zhHF/IOCJEISt4xOaBSTIIlKc=; b=OGxc+NpGOmU5VBQR4YX7pojFZaMLGpqNMFoHHLKnEJR+aBWkcOJodtXepu6Px17Fai 9zmaKf/MO3UruBNl+wrcOMTl+ng5o4RrsJBwhHZRiQ6yy+v3QrO+/JPFykYLnSyj0w0y PZOqSs5yuCoD24xfI1bd93ASt0ZzsvyL7e8Nmu4r3BE0y0uruswAk0Af3QeECDcMuDjg vCmrrCevNijsTNHS6+dTfGRNj2n6F1p+kDrg6Ejct6MtdSJGhUSbIqgO6XJLcll0z9tv LJRNowaZEdavi+2NE7KpNG8ASh9Wt4wk21Ftn5SCfm1gb33UTW35VTATHngmZihmHyfL 8+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782864461; x=1783469261; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NRsFNTp0mbWr+vlnr7zhHF/IOCJEISt4xOaBSTIIlKc=; b=g59XHCaczkhMYgIC+c0ZS/wNOc7s1KorJak8ZqFSD1QKA3ke6SE90YBaN6yryLXK4I q8Uk0o2Lj0+kbhfvahvKqEDRJ6fWde34cBTb/blZrjP9w8b0dD64RZFlxTFHKrzFPxYr /kuF6wfJZdRFhhAg9Uvll/BU3FbTIj+iR0U+hEc08+hmJA8iY3oygLMCKPnHgjWsAZ3y 1WstgiWbApih8HAsP8BlJwdXCFUgTnImy5SB2q4NuD+G+xRVRDFASttAl4DVb2fFWoaI CmXjezt4qZ/WXrYrOf03pr9Wb2vQFPoW/7RmzCNPndnf8ihbTvXmTQElRqL7Uvjrb6Y2 gOJA== X-Forwarded-Encrypted: i=1; AHgh+Rr/ZtGiKi0ihG76MXIz0YZpmaF8aMB5aXSvxfy+VXSmfN7OyIP23mDccsbeduUmMNTEy/SqnzU=@vger.kernel.org X-Gm-Message-State: AOJu0YxuMnpykwom1wlRcif82pt79B2VvQFF9Hlele7/3K5nXBGbCSu9 AWKdmYIcr+ji6KKDqCLyPrrk+sKti6QihYY7jGe+6e2O0/HoBVR/ey9K X-Gm-Gg: AfdE7ckz+2JvKEjFBu5q3xKclqTQiotRr+LE/pge5pf+EF6NAB2RkcfLjLdyu6lMvr/ +aXu6iKMPZ9lzHctug0C31oNCR4u/T/8AKJAaHoNpWTvW+UI4j7Z4wgEEf0/SiWt9Plycqkqncd R/2FVsBtd4MVzFnphqDRER53/5ngBcjHb0kQzZTSrLi5T90FmcILYyouL4f64NJa8Y0iABiCKEK Z/9jQWOlin3/T4j39WvPnzy/psDpF145fvW4dv9ScTaXof3P5ZxsL4bfpLKsnhE0+Jc0QwPd5Xj tI8uweE7YD145j33S8oLpdhaRK8EGE7JCkZZqWERRadNvZCCpNcrl700FwMpnN19ELL7NQ9Hwrz /XauLMgjdvtZpEZiI03tDH1nu1bhnkoUC+zRkaN3s2JulibtBLBC+NV4YCfEtrnNxye0VyYrMuy EKBZ95K89ovg== X-Received: by 2002:a17:90b:3944:b0:37f:7210:ccd7 with SMTP id 98e67ed59e1d1-3805272a521mr4755526a91.20.1782864461559; Tue, 30 Jun 2026 17:07:41 -0700 (PDT) Received: from john-p8 ([98.97.43.89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38095ea2e2dsm737009a91.16.2026.06.30.17.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 17:07:40 -0700 (PDT) Date: Tue, 30 Jun 2026 17:07:38 -0700 From: John Fastabend To: Sechang Lim Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Shuah Khan , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Stanislav Fomichev , Jiayuan Chen , Varun R Mallya , Ihor Solodrai , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf-next v4 1/2] bpf, sockmap: disallow update and delete from tc, xdp, socket_filter and flow_dissector Message-ID: References: <20260630145410.3648099-1-rhkrqnwk98@gmail.com> <20260630145410.3648099-2-rhkrqnwk98@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260630145410.3648099-2-rhkrqnwk98@gmail.com> On Tue, Jun 30, 2026 at 02:54:05PM +0000, Sechang Lim wrote: >sock_map_update_common() and __sock_map_delete() hold stab->lock and call >sock_map_unref() -> sock_map_del_link(), which takes sk_callback_lock for >write. That gives the order stab->lock -> sk_callback_lock. > >The reverse order comes from the SK_SKB stream parser. >sk_psock_strp_data_ready() holds sk_callback_lock for read, and after the >verdict tcp_bpf_strp_read_sock() acks the consumed data inline via >__tcp_cleanup_rbuf(). The ACK goes out egress, where a sched_cls program >deletes from the sockmap and takes stab->lock: > > WARNING: possible circular locking dependency detected [...] >A tc, xdp, socket_filter or flow_dissector program has no reason to >update or delete a sockmap, and redirect does not go through here. Drop >them from may_update_sockmap() so the verifier rejects it. It also >closes the matching sockhash inversion. > >Suggested-by: John Fastabend >Signed-off-by: Sechang Lim >--- Great lets get this merged and we will separately fix the sockops issue reported by the bots. Reviewed-by: John Fastabend