From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5052348BD30; Wed, 1 Jul 2026 12:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908393; cv=none; b=DvTKWK0jw9zgof1oEMQ3W98qbPtdjACOwlzwqnIy/l77cPBXUjV/wsKCz8vCZcvRQtKMcPv9LLkgryk0ZfbO7E9dIXf3cP1gEuo6brl5Sl0d5KrWTH+HUlEPkzZQVlbCw7vBO1C80jzpqTjpjAsfjVtjlH4LqVhTtnPaavXDo3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908393; c=relaxed/simple; bh=4cTXo5Fqh5clkUbUXZvF2uNeaiQZ8FEmGKbWUO7IJpk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JeKfSfUQuFD0gUtNSMG7fbLkatg30cr14mQCoS5m6zuQSqmEjaGP3NVPiAe4QyfR13kyfzfqDn1o7JIsGEfT2s8vC5YIAz3aD9DPNDigtmABQ+FrUUScO5SjKcsI/a+qU8oCv8Z7RglnWR1vEhjfqQSigYaJOEogwJ8IymJiIdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jtFKcyyZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jtFKcyyZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7A51F00A3A; Wed, 1 Jul 2026 12:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782908389; bh=VEtKY19/199sq5hBEK8vvyifwBLgNYHuvPBHa8OeONM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jtFKcyyZbtAmVVr+fjAxI0mN12qeBbZGTuUw9k9BXdiEiT6bA/LMEPDeHMMdvoAvt kXrgEn+QCk7kmuFJLiy8pfRdMmQE1MM0azpxyJhvk+ND3rXxhq37jO/aS/w3DkRAYB Yqib/iB/7fYJ/QRLpHsQqhAum5lS8ZiA39ewOynpW1hfKl/peb/UheJYM1BKEBR+zF KbgWdMRPPFSJ6dUqpLNUfnsNm9MdiQxnS/H+zUrOSwoQW/+ddPaWE2+IKllaKJ2jTL Pt79dgBU+Vjv+rcT/UjKjLAhEg30YCwfroYzWb5zRrtHvvm0jvgAmjc3XY0LBR0w68 M6TAGF0pGPmYw== Date: Wed, 1 Jul 2026 17:49:32 +0530 From: Sumit Garg To: Konrad Dybcio Cc: andersson@kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH v8 10/14] media: qcom: Pass proper PAS ID to set_remote_state API Message-ID: References: <20260626133440.692849-1-sumit.garg@kernel.org> <20260626133440.692849-11-sumit.garg@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 01, 2026 at 01:01:52PM +0200, Konrad Dybcio wrote: > On 7/1/26 9:44 AM, Sumit Garg wrote: > > On Tue, Jun 30, 2026 at 02:42:25PM +0200, Konrad Dybcio wrote: > >> On 6/26/26 3:34 PM, Sumit Garg wrote: > >>> From: Sumit Garg > >>> > >>> As per testing the SCM backend just ignores it while OP-TEE makes > >>> use of it to for proper book keeping purpose. > >>> > >>> Reviewed-by: Mukesh Ojha > >>> Tested-by: Mukesh Ojha # Lemans > >>> Reviewed-by: Vikash Garodia > >>> Signed-off-by: Sumit Garg > >>> --- > >>> drivers/media/platform/qcom/iris/iris_firmware.c | 2 +- > >>> drivers/media/platform/qcom/venus/firmware.c | 2 +- > >>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > >>> index ea9654dd679e..d2e7ba4f37e3 100644 > >>> --- a/drivers/media/platform/qcom/iris/iris_firmware.c > >>> +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > >>> @@ -110,5 +110,5 @@ int iris_fw_unload(struct iris_core *core) > >>> > >>> int iris_set_hw_state(struct iris_core *core, bool resume) > >>> { > >>> - return qcom_pas_set_remote_state(resume, 0); > >>> + return qcom_pas_set_remote_state(resume, IRIS_PAS_ID); > >>> } > >>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > >>> index 3a38ff985822..3c0727ea137d 100644 > >>> --- a/drivers/media/platform/qcom/venus/firmware.c > >>> +++ b/drivers/media/platform/qcom/venus/firmware.c > >>> @@ -59,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) > >>> int ret; > >>> > >>> if (core->use_tz) { > >>> - ret = qcom_pas_set_remote_state(resume, 0); > >>> + ret = qcom_pas_set_remote_state(resume, VENUS_PAS_ID); > >> > >> This should not be in the middle of a mildly related series.. > >> The PAS IDs should be centralized into a single header. And the > >> name of the driver shouldn't be part of the define. I would guesstimate > >> that on the secure side it's probably called VPU or VIDEO > > > > I agree with your comments, this is something I would also like to > > consolidate on OP-TEE side as well: see discussion here [1]. > > > > However, the patch itself was needed to do book keeping on OP-TEE side > > but I can drop it since anyhow the video isn't functional yet in > > upstream dependent on the proper IOMMU support. > > For this patch.. I think QCTZ may be ignoring the argument so it > may not matter.. on a second thought you already have it reviewed > and it's already a cross-subsys merge so might as well pull it in, > worst case scenario it'll revert cleanly Thanks, I will keep it then. > > Once this lands, please move all PAS defines to.. hmm.. qcom_pas.h > sounds like a good candidate? Sure, I will propose that as a follow-up change. We have to agree on common naming there. -Sumit