From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ED88449EB0 for ; Thu, 2 Jul 2026 08:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782982578; cv=none; b=SQcxD64jTAuLKV1LfzXTE4k8/fQvyJVJAIJouT1jJ1iedOke7fk6CAS3V+ICxaR3IOY7yQinImeo0AylZrobkzauZ3pAYWsg45MSeOIpx07oI25A1bADQWzkuNzx/T8qJYPFb/WZGvPsg9y/QIwu88dyCp5Lml6TUKkS1QNW+5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782982578; c=relaxed/simple; bh=IqR1f/AEimWy9td6sTkb7Jq/+F4NeD8zy8Z1IlmH0fM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RszeWfLg9y7d1g1SBKe/R5HOpFYhSnVUqpDGr18o9Wnup5qsJ8tINxCqmFGEgVNEK+z83WJYNaEISeGSdf8WTNLyGSzalHv5G8PBCOydU+cl1k1bOpGTwWjKcKLPVLl47QWZ/TYTDu6d0HGFOrDJqCAdVl5J8jsAJhsN2uymLzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QQKxZv9Z; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=g+H1OBUj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QQKxZv9Z"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="g+H1OBUj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782982575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jzu6+yi+0UPBChb/E9Oct0h9dnkvsRVovpFSB+irYu0=; b=QQKxZv9ZUwB8+EDVgDDZRNLjyMvPfdTPuE9l0AlqGR3rcvgiiAiOlRErgQaxqbM+Q0EmiD DgBhoY6J6TOA0ScSxYAVuauZrygt+QsNNnoA8zbkIM9rU/9TYGQlOabOi4m1ACzTK9mWmR 7AsZmmHxpeMR9MZjVadOkF/0QAba0iw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-0uFqEfyGNKaIcwi9H2APVA-1; Thu, 02 Jul 2026 04:56:12 -0400 X-MC-Unique: 0uFqEfyGNKaIcwi9H2APVA-1 X-Mimecast-MFC-AGG-ID: 0uFqEfyGNKaIcwi9H2APVA_1782982571 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-492714d002cso11302695e9.0 for ; Thu, 02 Jul 2026 01:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782982571; x=1783587371; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jzu6+yi+0UPBChb/E9Oct0h9dnkvsRVovpFSB+irYu0=; b=g+H1OBUjhsMBbbQW0qzr+CQZod/o5/IvBj2mdzDYzZ2Kd1COtqsUb4fLZHQiuCLDv1 FXTSkJTGHC03c5CIBDky5P385pJXxoUGYjzh9lGEig+OyrIiLNle7OdDiQ22ntFpaRzY WoxmpdSBi6vikaaMbxC5b4tf6xpdQ6y2tf1WyegdSbHMj92t5Kz8Ma1yhyLLP27ji11Q chnKeTNzoxWlQT+51J7v0Ln4pYCy/mNxbPnQtglPHzaI0FyPa0TiXjzOSywIQBW9FDJk /6K73a9CVDAh2QyA8DW2XSyu0fOobhVW6dA6I0DU66IYEJT3lJ+sZUTIYdDgq21KTIGs kLYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782982571; x=1783587371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jzu6+yi+0UPBChb/E9Oct0h9dnkvsRVovpFSB+irYu0=; b=FNhzZg7/pqw1Io9w2UeOP3VcO0UVj0kM4QmIh2DvdmLH14EkiRCRGsYvm/GKJ0hEYj vqB9RPBxLjILkm/n/q61pCepRO36dF8mnTRljKByg/reCtW4GZcAc3jI3fZkSWjaEFB5 OPdrTSjLHV72EqlKNJn/eHqM6eDzB9fJxtNn7jvYbUl+SFTcnbB1zuw4zA7N8cy69Aih LN0njKZEaHUVEtSPkBVIhmlsl/hphQ2ELghZtJvS1Yv/0tPLIR/AnOdzGjh0ZiZnYtTU MnpvA9XVFIn5NCYeQiGENkkGMd4FjumcoE0vnjsbiUsLiQXiLEgQFg3mJkQJ+0PmwnrA IyhA== X-Gm-Message-State: AOJu0YxZXViHqs4rKbuOpi9apRdafdoW4qONmW44fe8wW/v01jyDCkmi 1T5OWh9q1MlaZ7GLgbarw/W3XpWeRYL5BZe7P912mEkhfznVM6GSsc0D0IY4b2KctpNNu/8BVjQ c0Eua+xC6P68Rtk0eWafMYHWpQUtBfhKLHcUaq8htw4V0sr1MKCPUsaygHg== X-Gm-Gg: AfdE7cnBkCfEp0XNzHeu1hDPCT5mdz2ExP8+uhCpFt5c/Pvb9ZwZIXibLEDL97rpZ+f KkjESNyo3uZVtLQ8irCcLkTWbCkYRxk5HGb5N8Elw5KVw1hk8Piv7tsHlw54jCw0Cyfj2O1U8rR 9vAhWeYYm8XGJkpuTN5UgjeYXsWREApKUeK53oRu32VN7bpWkWf3NX70b5URoSBq2Lar+yCS2Vg KO2Zdn4socwORhr7Pq/3fUNY+FhXAZTo3WhsyPq+2V6WJkdDjw6E6l7ZyafrctYS9F7qMW6FRPV frPZhdNdjjb33+DeKlJVqiM6aQAPiRwlAV4k2vzamRRsx03lXxuQYyP5OFCFWbDg6eRY0LF1IQh 3Zx6J4UGfhI5M0zowHHxErR2Xl6HaC3xePeUphRH/0IctMPynnHAUHpCZlbRT X-Received: by 2002:a05:600c:5391:b0:490:c032:ae92 with SMTP id 5b1f17b1804b1-493c3df2b42mr53317705e9.33.1782982570897; Thu, 02 Jul 2026 01:56:10 -0700 (PDT) X-Received: by 2002:a05:600c:5391:b0:490:c032:ae92 with SMTP id 5b1f17b1804b1-493c3df2b42mr53317205e9.33.1782982570427; Thu, 02 Jul 2026 01:56:10 -0700 (PDT) Received: from sgarzare-redhat (host-79-34-22-35.business.telecomitalia.it. [79.34.22.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f27bsm6829505f8f.30.2026.07.02.01.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:56:09 -0700 (PDT) Date: Thu, 2 Jul 2026 10:56:04 +0200 From: Stefano Garzarella To: Bobby Eshleman Cc: netdev@vger.kernel.org, Jason Wang , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , kvm@vger.kernel.org, virtualization@lists.linux.dev, Xuan Zhuo , Eric Dumazet , Simon Horman , linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , Eugenio =?utf-8?B?UMOpcmV6?= , stable@vger.kernel.org, Brien Oberstein Subject: Re: [PATCH net 1/2] vsock/virtio: collapse receive queue under memory pressure Message-ID: References: <20260626134823.206676-1-sgarzare@redhat.com> <20260626134823.206676-2-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Wed, Jul 01, 2026 at 09:34:35AM -0700, Bobby Eshleman wrote: >On Fri, Jun 26, 2026 at 03:48:22PM +0200, Stefano Garzarella wrote: [...] >> +out: >> + if (new_skb) >> + __skb_queue_tail(&new_queue, new_skb); >> + >> + skb_queue_splice(&new_queue, &vvs->rx_queue); > >I think the new skbs will also need skb_set_owner_sk_safe(skb, sk) >when adding to rx_queue? IIRC we added it in the rx path, mainily for loopback to pass the ownership from the tx socket to the rx socket, but here we are already in the rx path, so the skb will never leave this socket. Maybe it's necessary for the eBPF path? In any case, I can add it, but if you can help me better understand what it prevents, that will also help me add a comment above it. Thanks, Stefano