From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: chelsio: cxgb4: Use str_plural() in mem_intr_handler()
Date: Mon, 6 Jul 2026 19:40:06 +0530 [thread overview]
Message-ID: <aku3PjxIvUxAqhed@chelsio.com> (raw)
In-Reply-To: <20260704121010.201016-3-thorsten.blum@linux.dev>
On Saturday, July 07/04/26, 2026 at 17:40:11 +0530, Thorsten Blum wrote:
> Replace the manual ternary "s" pluralization with str_plural() to
> simplify the code.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
Thank you.
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> index 6871127427fa..29d7b786e51e 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> @@ -33,6 +33,7 @@
> */
>
> #include <linux/delay.h>
> +#include <linux/string_choices.h>
> #include "cxgb4.h"
> #include "t4_regs.h"
> #include "t4_values.h"
> @@ -4867,7 +4868,7 @@ static void mem_intr_handler(struct adapter *adapter, int idx)
> if (printk_ratelimit())
> dev_warn(adapter->pdev_dev,
> "%u %s correctable ECC data error%s\n",
> - cnt, name[idx], cnt > 1 ? "s" : "");
> + cnt, name[idx], str_plural(cnt));
> }
> if (v & ECC_UE_INT_CAUSE_F)
> dev_alert(adapter->pdev_dev,
prev parent reply other threads:[~2026-07-06 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 12:10 [PATCH net-next] net: chelsio: cxgb4: Use str_plural() in mem_intr_handler() Thorsten Blum
2026-07-06 14:10 ` Potnuri Bharat Teja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aku3PjxIvUxAqhed@chelsio.com \
--to=bharat@chelsio.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox