From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1871C367F31; Mon, 6 Jul 2026 10:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334640; cv=none; b=M/v1Io8iWKN+bDpxzN1n1ifcoaMrVc0LXPKGtgXJ7dN4Oz6Aak2GsiCNj3+14ZGwhzRgkZPAZGrQ4KR0mXG3bTHA4qK+FuPlz5BoM41BZyaol1c6y+mrgnmttXUtgwxtaOtfibfaTS/4FuGGJee1bvoKdY0gD6brHsIU9RJS1JQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334640; c=relaxed/simple; bh=WnzHF1EIRgC4bodmT0Ir1QqzO4NEdueoU2BNb1PYBeg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g3b2o6FZdZnAO5/epsP5VHqY/BKtfpnMRT6iXgDY2TlLqLU/NRNbkC8CDP7vFecIlbMJqXrlI05f1mj1VkZpNFHtJg/qzSV/KvzPd9qEQKXQhDFF4Z6UsEtxEeOWfYBSlmPyeUJfxWDI5lBlQBUguWmpDGM1mA4ctTCRAQiXpGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=oIi5TvNt; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="oIi5TvNt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D2pcKLlrTsrDyIcpoUo11RFFWa8w4cPretypMw4hkRQ=; b=oIi5TvNtWmuf9x4XqQfKRs2GsI +DgkoslCUPQ/lTjQ/RwXF7bvSGnJ3/lFBbfV81+MtuynbByzUsdcK0MM46HDM/LysQVWGsTN+AoXj 6WkR3nKFLfTpodbDfH0fI7VtE8zvGN1wnYUpKPKAKu/h9ZQHwJMN/BE/I7rDoFa0GS3ugCvGsT6XS ZzGrqu3dbcWpHbRRvlnuKhvNS9hKNzl4+0aR2kMJsVbDw4vbTBDJynYjv2jzC9PCnoWMoM+Z8ZgQQ 9tQqftnu1cQ36D5Ph8tw73SnP97XtvGf53W1cfpmjbWbQQJT7bUtyDxXjNNY9rn3KwCJiV0fHq6co KbM6xpmQ==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wggnj-001MGb-0v; Mon, 06 Jul 2026 10:43:47 +0000 Date: Mon, 6 Jul 2026 03:43:42 -0700 From: Breno Leitao To: Satish Kharat Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sesidhar Baddela Subject: Re: [PATCH net-next v11 02/12] enic: verify firmware supports V2 SR-IOV at probe time Message-ID: References: <20260703-enic-sriov-v2-admin-channel-v2-v11-0-5b739f1fe9e5@cisco.com> <20260703-enic-sriov-v2-admin-channel-v2-v11-2-5b739f1fe9e5@cisco.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703-enic-sriov-v2-admin-channel-v2-v11-2-5b739f1fe9e5@cisco.com> X-Debian-User: leitao On Fri, Jul 03, 2026 at 11:08:51AM -0700, Satish Kharat wrote: > During PF probe, query the firmware get-supported-feature interface > to verify that the running firmware supports V2 SR-IOV. Firmware > version 5.3(4.72) and later report VIC_FEATURE_SRIOV via > CMD_GET_SUPP_FEATURE_VER. If the firmware does not support the > feature, set vf_type to ENIC_VF_TYPE_NONE and log a warning so the > admin knows a firmware upgrade is needed. > > V2 VFs are only ever enabled later through the sysfs .sriov_configure > path (enic_sriov_configure()), which rejects ENIC_VF_TYPE_NONE before > calling pci_enable_sriov(); there is no probe-time auto-enable, so > firmware that lacks V2 support never exposes VFs. > > VIC_FEATURE_SRIOV is assigned the explicit value 4 to match the > firmware ABI. Slot 3 (firmware's VIC_FEATURE_PTP) is reserved with > a comment rather than a placeholder enum entry, since PTP is not > used by the upstream driver. > > Suggested-by: Breno Leitao > Signed-off-by: Satish Kharat Reviewed-by: Breno Leitao