From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B03431A057 for ; Tue, 7 Jul 2026 09:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783416476; cv=none; b=Z3ThRDgkjH0lOTDBYJBUvItCiLQPeHmna/UsSH0sC3pFTomaNKRVplWhWT0TxkfhDoiNzew7I181VNWLtGfkxwsZH/qIu6oyhGhhjJVa7TerjVKjP49NWYCC+2NxvUpDy3HneG6HP+OEwnPrz7XNCNH1HgkQMyeA9giedyCoMjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783416476; c=relaxed/simple; bh=3bYECwpBfkTcXe9Xf4qgJEYNbyztdqohJjIZZ7uI0/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MOGLa4g6TsbDpx3R0ZP1kRJhdIf5Ln7Z8TGrbquqAJsdkxEj2mkiauSxlhsFgqzKNLRxyLLV5sGlPveaezVL5/EiGhiMXvVrgjBeMsHI24gn9rZVmmwQe8dk60OU8zT56FcUH7Dai6KBVKixWNMxGWbSrUwZvMWxSkHGsmIL/68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aU6xEIv5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=EgRcJsUM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aU6xEIv5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="EgRcJsUM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783416474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dWXC2U5pS/sHIFMNKjcnHZ2j56kpHPifAM+RlNplU0Q=; b=aU6xEIv5GCjhsSKNRdzG9RpiStMs+glGmXSjsshuXZAi2pBsxP6nRFA3TXx6lVjgeC7kcM lW0kbn5EJzfXk7i/edh3z6T7b8BEh15YZjYfbfxh3RKm/XmWu5sRs3ZYr+E7QevEElJWMq UY8JwrWyaZYj8M8fyD4ksVvvmvdMT9I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-4xBJR1XENn-0EC2SLrHBlQ-1; Tue, 07 Jul 2026 05:27:53 -0400 X-MC-Unique: 4xBJR1XENn-0EC2SLrHBlQ-1 X-Mimecast-MFC-AGG-ID: 4xBJR1XENn-0EC2SLrHBlQ_1783416472 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493ce08a6b4so40298915e9.1 for ; Tue, 07 Jul 2026 02:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783416472; x=1784021272; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dWXC2U5pS/sHIFMNKjcnHZ2j56kpHPifAM+RlNplU0Q=; b=EgRcJsUMwNTfmjcjtTEh0B3qY8pZ2jTTl4RMibEsP2AC6oPkcA1m9ed8kO3wmfmciW XgFCGvYzbmiVCC1ESidbypkqxh/Px2k4Wnl7ckZlV5uoXSdKREqljgNJ6Y4d5NcJCUAH RPvwbPonvKQhsya0Xq+zx8i0HrVp5hTwxRMjr32/hqG0M7t/i1haIHHH+5YZJJFFUatC SrO/2WMMwcbsu/2ei/zknM/dpS7cUqt9Z2njY8CgcAcUaD4audPIfGXOkNzdSc0O6EXA VHS5VTYq2sqfyuSGP2Sgcclm0jabmKiMSEgjBJFbmvSusV5mgBmCtBHOTY2w7Aq0rt2g K2yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783416472; x=1784021272; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dWXC2U5pS/sHIFMNKjcnHZ2j56kpHPifAM+RlNplU0Q=; b=TgCqIqaw+/5sHLCrKkIKYKKCQuFApZ6CAgCUTOgyW8eTLlJ/9VE3cYGPsnN0sIoZIr ZH2a9cZnd0N9hPuQryOLFudScPu1tmEb/OVLPeukXAYB64ipmkFKdPUtC8yqtMVp8Rez JKtEyfitrgqC0RTUqQYFsseD/mZ+wF+VrM8y6GKIas/2g/9aByTCKZMdI/SBbslUhhcU I9M1XxvbiRwGiTUa/a/POb5xDa4RtCGlgOAihC5J2t3ZjiRE9IvPGQTquv4zyky8SE0a VZILSu4Ub1afOEfsHkjxVpOFIUKKwIsVF6JyVoMsoaAaY7nq7FXum+bpOfdLA+E/EfKL caYQ== X-Gm-Message-State: AOJu0Ywea2vrHaaiaBypRHIO9IcZr/NY0VRypU8mzqhCh7XZE4UVMyHi vHdvTpLtHqNEzu7tqozaEuBMaz7C7h6T1cJxRopazGbjk+foi2oEzRe4t5Ys1EzXAfdqusVDzbz jp05clJ3thjpvxBFzfL8+2MO8UYY7r5J6vVzTWLd/733raFxkSjpO/6932Q== X-Gm-Gg: AfdE7ckrcjeR4oze1940ixkchWEmsNtZ3qYOR7s1tvLN4+Hc0EVijnbk+tCmEFDS+cE 2ewvbsXXCWGpGhGDcpkUr/YSGY9VU9DFfq9pjx04ZVKdsILdERxSBw1cDQ2O8uuai+4+GmYu6p7 UexUeT2hIdn37DN1Q5obXd5C3zO+IS5XhPcmpVxzawptV4oEeS20nFB859zAtC8vPSjLL8OSUnP 2edMSxOAI/cKRaQCvPFbAuLMQs3L2prC3Z9P3ihrrrrP3yknmJrZIxEs1P8mHD8fDoiIH6YannP wYsGlLVS973UD5aPqI16FK2oAqMNoZ2SXhOcjauhnuiv0+A1qLf88zr3BjfCQXKczVjqnQoXrYO XZPB4+Rf7zO1IlxtLlIE761ixs9b/+2+W2NppSFfrYA6hlT4jF42hTV76cNrN X-Received: by 2002:a05:600c:6ad0:b0:493:c2cc:aecb with SMTP id 5b1f17b1804b1-493df0a08ffmr34351375e9.38.1783416471672; Tue, 07 Jul 2026 02:27:51 -0700 (PDT) X-Received: by 2002:a05:600c:6ad0:b0:493:c2cc:aecb with SMTP id 5b1f17b1804b1-493df0a08ffmr34351085e9.38.1783416471154; Tue, 07 Jul 2026 02:27:51 -0700 (PDT) Received: from sgarzare-redhat (host-79-34-22-35.business.telecomitalia.it. [79.34.22.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f4e3afsm48240745e9.7.2026.07.07.02.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 02:27:50 -0700 (PDT) Date: Tue, 7 Jul 2026 11:27:36 +0200 From: Stefano Garzarella To: Bobby Eshleman Cc: netdev@vger.kernel.org, Jason Wang , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , kvm@vger.kernel.org, virtualization@lists.linux.dev, Xuan Zhuo , Eric Dumazet , Simon Horman , linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , Eugenio =?utf-8?B?UMOpcmV6?= , stable@vger.kernel.org, Brien Oberstein Subject: Re: [PATCH net 1/2] vsock/virtio: collapse receive queue under memory pressure Message-ID: References: <20260626134823.206676-1-sgarzare@redhat.com> <20260626134823.206676-2-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Thu, Jul 02, 2026 at 01:09:20PM -0700, Bobby Eshleman wrote: >On Thu, Jul 02, 2026 at 10:56:04AM +0200, Stefano Garzarella wrote: >> On Wed, Jul 01, 2026 at 09:34:35AM -0700, Bobby Eshleman wrote: >> > On Fri, Jun 26, 2026 at 03:48:22PM +0200, Stefano Garzarella wrote: >> >> [...] >> >> > > +out: >> > > + if (new_skb) >> > > + __skb_queue_tail(&new_queue, new_skb); >> > > + >> > > + skb_queue_splice(&new_queue, &vvs->rx_queue); >> > >> > I think the new skbs will also need skb_set_owner_sk_safe(skb, sk) >> > when adding to rx_queue? >> >> IIRC we added it in the rx path, mainily for loopback to pass the ownership >> from the tx socket to the rx socket, but here we are already in the rx path, >> so the skb will never leave this socket. >> > >Ah that's right, I stand corrected. There is no sender to leak in this >case. > >> Maybe it's necessary for the eBPF path? > >Looking through sockmap, I don't think it depends on skb->sk being >non-null either (it reassigns owner to the redirect socket anyway using >skb_set_owner_r()). > >Sorry for the false alarm. LGTM. Thanks for checking! > >Reviewed-by: Bobby Eshleman > I'm going to add a threashold as Paolo suggested. Do you prefer to look at v2 or should I carry your R-b ? Thanks, Stefano