From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8030F1E0E14 for ; Fri, 10 Jul 2026 13:32:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690323; cv=none; b=BAHbAzUPKeLvAIarqU46i1fs2heQcMNkVHVnEvndhvnk0i2lWkM6IgHsowTzlkNXW1V6wz95UyIz+ivN9CC+JzY5SHJgQT/z5ThgbcWORSpKCAO9Hb6/ce8MLSZMKy2ksFXJUogyQhpnIEASDbqpvXb4SRDJlWjlRE3UWUvpAGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690323; c=relaxed/simple; bh=0kCTodwMNybNFHvFl8c20+Pfoq3qaWcGnR+gA/Fw/Ow=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ennI7rMdQwV6qWa6Rw+eh0RfFPXaa1uGB5dr+FRyfmXHdrrZLwXbjvoYckdZBhAntIxAWD7DsF2iPpCrRHa04ZhsHcUhT5jFB3qg8SgecVnfN8ctPjFGHZ/xW0wv4N8cxaQYVsO5AbiQ/BLZjVpiMjz19cpuI0DVlCd0Is9Ec+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=YVmQEGeK; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="YVmQEGeK" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5A6073F85F for ; Fri, 10 Jul 2026 13:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1783690313; bh=CRjw6u/TimhdsdLAKCBwY2E0h0Xmbg9SBDdL+xLx6es=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=YVmQEGeKY5DNRktZoKSqGEt8BiPYMVyZMYXPgU/duGMIcAGT8so5ZTKE9pQODcdxN uq4uZoAwgapyNhL1DxwOkT22AcOAXxTjTEl5EhEou+iMbA6klRphIfmU/b1mCjO7YS fBXs7N9iSaiVX3MFqj0bo3BtDMSxohPzMLqNhTMHXKMwrdK77/39wGakakqEqLu8N1 ncVK3i4ufqzAbNXjLI8Hob+DmDmG0JY6QhhbSjEborizmi+8Nmi9ZHyaFRX8gd8/8l lY4GkRR/qCsF6B8S4kr4CDh6NXmYQxrq7CoBRAWoDuhnkAeIZzIQHFbTdUl3xnGUQl ux/4ZH+7UfKlfh84CiKUMIp3mCbxeV452p5uAv/+fHv+jCD9o2h2b71vUPP+NLvZCg fANV4XgU2Mkl70mFvYL6Kjkg9MTCOcXbXdNB1GEBhFo46Ax0ipoB81Dv3gsImEgTYb dae5uye8XvblBKttKflPEw6JRph5zRunfaxD5lrIDYWUljGIX2kaApGBtM8hgd1DX2 qr9FFltEubEugJ11dYGKZk9vCNzoBuR+H1CQytRDAJEV1HJ4dJBtpe+CnE8vy50qgk T11LuQ4T5AigknyEQP8+CLIqI3Ynlr0mug9u++JHcjNzBn2hV0HvZiHtpCyeuAXOFf ShSveZyy8NtOnks/5MG897C4= Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490a767b782so8754185e9.2 for ; Fri, 10 Jul 2026 06:31:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783690313; x=1784295113; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CRjw6u/TimhdsdLAKCBwY2E0h0Xmbg9SBDdL+xLx6es=; b=DvH0luWexfLLf+PFuTFs3Iqu8yaX3nioV6n05YQTTBEpx+CBMbOYUW2PnDJeCWxNa2 ua7T0E210dnakO9JqfbIvWJKwqjpWS5FBHp39O/K0PI3aGJdA9afflOa/i6n0wOIQe28 9zFzuXFRjbn5F9J15YsUp6aB5vGVgfXifiSFNpUV/mIugaiihfCdBNN9wItchrA22tGw k/sPvkvulz2FzLsOhBcLvn1mXYk1dzzZYZy4dkxaKt13wJ9uHtvRCkDgG1sLVCnIucdR A3zDbXVgwj2T3ppAsab3BtirBy3al6xZrfVaRYvDoWRL9pm8Z7jFXO25Ek6sd/ab4MWh yBZg== X-Gm-Message-State: AOJu0Yx+VU5eFmqrHVQsVhzPIX5mA39nYGyXPNoXgxY2JRa83Dg8cwto RVSzwo2eKapsQV5uAufOtH8jkc2IAPhsQ4+0qZF10EqYN8wp5QUM9obf2RvqhylBJUhP7SnvZ79 zGOaPkXcuecqLlOgvqW71LoNpXwKVJ1ICPhUUzctV1vcpT6C7UbNffLPwTDarMR6K94YF0vsMEw == X-Gm-Gg: AfdE7cl5JVTmbx2XVYHpmoDjwHBPYyQ00a+0dok+lYA2/6gJcb/SQlftvT+rhpyhl8q bkYAs+33IT2hEuT5m2vpvgCat9osHbsS4Oy921+5X0s4q5zvEof7n/gS0qOmgoXE474fHnVQ+ra kcgvHDFZ3Y/G3Nk0jQtK5ojbhlHHkf/a9jsPN0w22etZPZXSNJkvq8h1tozRm5Z9zMJmAw0qWeh BAUDuXU4rYJeIaEAEzUtPRwySTq7sMIpnzngN1FcEmUt6GQCPMpZIqsfMk3ne02zavm3ujtvS8a ZauitcD8SuqAu0yIGGXjjh9U3T6MqCVwrmFGhjSW/fDy+YAa77ZhNYpylWhOpmuA2ZrHRNpPU49 nWrHZLGTL1HRgvxyzLo++m5/13t/sR0staJH0VetW0D/vDK7kWn3c2BhbGTIbUMfzSIiPKS+KcQ kbNoYRqw== X-Received: by 2002:a05:600c:4692:b0:493:b750:bd20 with SMTP id 5b1f17b1804b1-493e68a5f91mr120361655e9.15.1783690312836; Fri, 10 Jul 2026 06:31:52 -0700 (PDT) X-Received: by 2002:a05:600c:4692:b0:493:b750:bd20 with SMTP id 5b1f17b1804b1-493e68a5f91mr120360905e9.15.1783690312205; Fri, 10 Jul 2026 06:31:52 -0700 (PDT) Received: from localhost (93-40-74-111.ip37.fastwebnet.it. [93.40.74.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f567eadfsm37394065e9.6.2026.07.10.06.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 06:31:51 -0700 (PDT) Date: Fri, 10 Jul 2026 15:31:50 +0200 From: Alessio Faina To: Andrea Mayer Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Po-Hsu Lin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , stefano.salsano@uniroma2.it, Andrea Mayer Subject: Re: [PATCH net-next] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old Message-ID: References: <20260708152745.2430714-1-alessio.faina@canonical.com> <20260710152211.63eb25d604ea0aa2b3707d68@common-net.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710152211.63eb25d604ea0aa2b3707d68@common-net.org> On Fri, Jul 10, 2026 at 03:22:11PM +0200, Andrea Mayer wrote: > On Wed, 8 Jul 2026 17:27:45 +0200 > Alessio Faina wrote: > > > In case iproute2 is older than version 5.14.0, released ~Sept 1, 2021, > > the End.DT46 support is not available and the host_vpn_tests test contained > > in the srv6_end_dt46_l3vpn_test.sh file is failing in some kernel backports. > > This is the result of those tests: > > > > ################################################################################ > > TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant > > ################################################################################ > > > > TEST: IPv6 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ] > > > > TEST: IPv4 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ] > > > > TEST: IPv6 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ] > > > > TEST: IPv4 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ] > > > > TEST: IPv6 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ] > > > > TEST: IPv4 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ] > > > > TEST: IPv6 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ] > > > > TEST: IPv4 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ] > > > > To amend this, check the current running iproute2 supports the required > > feature and, if not, just skip the test to avoid a failure. > > > > > > Signed-off-by: Alessio Faina > > --- > > .../selftests/net/srv6_end_dt46_l3vpn_test.sh | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh > > index a5e959a080bb..406c6a3d253e 100755 > > --- a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh > > +++ b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh > > @@ -510,12 +510,15 @@ host2gateway_tests() > > host_vpn_tests() > > { > > log_section "SRv6 VPN connectivity test among hosts in the same tenant" > > + if ip route add help 2>&1 | grep -q -i End.DT46; then > > + check_and_log_hs_connectivity 1 2 100 > > + check_and_log_hs_connectivity 2 1 100 > > > > - check_and_log_hs_connectivity 1 2 100 > > - check_and_log_hs_connectivity 2 1 100 > > - > > - check_and_log_hs_connectivity 3 4 200 > > - check_and_log_hs_connectivity 4 3 200 > > + check_and_log_hs_connectivity 3 4 200 > > + check_and_log_hs_connectivity 4 3 200 > > + else > > + echo "SKIP: SRv6 End.DT46 is unsupported by the installed iproute2 version" > > + fi > > } > > Hi Alessio, > > Rather than inlining the check inside host_vpn_tests(), I think it would be > better to follow the pattern already used in srv6_hencap_red_l3vpn_test.sh, > where test_iproute2_supp_or_ksft_skip() is called before setup(). A similar > function here could exit the whole script with $ksft_skip if End.DT46 is not > supported by the installed iproute2. > > Thanks, > > Ciao > Andrea Hi Andrea, Thanks for your feedback, I will send a V2 with the requested changes. Kind regards, -Alessio