From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB03B3C3BFF; Sat, 11 Jul 2026 16:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783785993; cv=none; b=OXu916nRsi4axAo4E1F8zjYwNiaD7ymi0mB72eMfWejWC5wlT4ElMQK3jZqe0ffnFJbka0mM5qAz0XkdhZ+HSfj9Er1dZizquaaLkrIF5qIXmB5t0ghAsnlcrQd2fK71Q86Fmmi6NhaWzeCrHIbeGhvToCkvjQtE8+XLPd4Rt+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783785993; c=relaxed/simple; bh=DoyxLKmFI5e+L8bsmYWhepaKIMj63758qF7Q9IHNvJU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tyrrPrJ+8HATUrLwoVq6zdpGcXh2+8D4WTK1Orw9UwQJIlsYsf2b78xk0mdL+OjWTxovgk2kz4R2lzvGPoN6fGqxx0R5tQgDqiQZfmiw4bIYZQkyOSvhQjXIE80AModfKk2qvJXU/kIHmW5H2jqVDiYs4w3bsXryPGqcNSiIoxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZZ19zs+R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZZ19zs+R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 518971F000E9; Sat, 11 Jul 2026 16:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783785991; bh=+QuIe/JXClOlWX4qdoKvsVboO8bvQ4xPcjrHdiLMqdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZZ19zs+RX0qgmc6OxroxmqWRc+kVvzolvhSNhDXF4fCbFaMe+AcAzIda03cdJGa0y +daVX+++fl8kWoxj48t76nY/0TrrJADWUWqcSlj3PNCnMKEg60lPZ0JFH85d/pSuES JY1O72m2XSSdTD5GQyRUMNgHGR4qfdyZ2K19SuENFJjgE/NVLPABoD8qKWUGU29J0W hju4pjk8CO0X+JR3+cu7cLk2viqFio67e08T3IjbtgWKyHTGCdAKLocCoQF3krODMe SNbFEqKoivoxfzQuFVFMVFNLNzr7Ke9Vq2M3bCpYQAqwl5hXFCK3oZTS8Ja+ph6OXe j+K1CTUi3fPbg== Date: Sat, 11 Jul 2026 11:06:26 -0500 From: Bjorn Andersson To: Sumit Garg Cc: konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jenswi@kernel.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg , Alex Elder , Konrad Dybcio Subject: Re: [PATCH v9 11/14] net: ipa: Switch to generic PAS TZ APIs Message-ID: References: <20260702115835.167602-1-sumit.garg@kernel.org> <20260702115835.167602-12-sumit.garg@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702115835.167602-12-sumit.garg@kernel.org> On Thu, Jul 02, 2026 at 05:28:27PM +0530, Sumit Garg wrote: > From: Sumit Garg > > Switch ipa client driver over to generic PAS TZ APIs. Generic PAS TZ > service allows to support multiple TZ implementation backends like QTEE > based SCM PAS service, OP-TEE based PAS service and any further future TZ > backend service. > Please find an immutable branch with the dependencies for this patch at: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260702115835.167602-2-sumit.garg@kernel.org Alternatively, if you think there will be no conflicting patches in the time leading up to next merge window provide an Ack and I can pick this through the qcom tree. Thanks, Bjorn > Reviewed-by: Alex Elder > Reviewed-by: Konrad Dybcio > Signed-off-by: Sumit Garg > --- > drivers/net/ipa/Kconfig | 2 +- > drivers/net/ipa/ipa_main.c | 13 ++++++++----- > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index 01d219d3760c..a9aff1b7977d 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -6,7 +6,7 @@ config QCOM_IPA > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n > select QCOM_MDT_LOADER > - select QCOM_SCM > + select QCOM_PAS > select QCOM_QMI_HELPERS > help > Choose Y or M here to include support for the Qualcomm > diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index 788dd99af2a4..3cd9e44680e9 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -14,7 +14,7 @@ > #include > #include > > -#include > +#include > #include > > #include "ipa.h" > @@ -624,10 +624,13 @@ static int ipa_firmware_load(struct device *dev) > } > > ret = qcom_mdt_load(dev, fw, path, IPA_PAS_ID, virt, phys, size, NULL); > - if (ret) > + if (ret) { > dev_err(dev, "error %d loading \"%s\"\n", ret, path); > - else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID))) > - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } else { > + ret = qcom_pas_auth_and_reset(IPA_PAS_ID); > + if (ret) > + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } > > memunmap(virt); > out_release_firmware: > @@ -758,7 +761,7 @@ static enum ipa_firmware_loader ipa_firmware_loader(struct device *dev) > return IPA_LOADER_INVALID; > out_self: > /* We need Trust Zone to load firmware; make sure it's available */ > - if (qcom_scm_is_available()) > + if (qcom_pas_is_available()) > return IPA_LOADER_SELF; > > return IPA_LOADER_DEFER; > -- > 2.53.0 >