From: Breno Leitao <leitao@debian.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
Andre Carvalho <asantostc@gmail.com>
Subject: Re: [PATCH net 7/7] selftests: netconsole: ignore busywait errors
Date: Mon, 13 Jul 2026 03:41:04 -0700 [thread overview]
Message-ID: <alS6Xdmj-dX2at9z@gmail.com> (raw)
In-Reply-To: <20260710-net-sft-fix-containers-v1-7-a2915c294ef5@kernel.org>
On Fri, Jul 10, 2026 at 08:04:47PM +0200, Matthieu Baerts (NGI0) wrote:
> In these netconsole tests, bash is used with errexit (set -e). It means
> that if the busywait timeout, the tests finish without printing an error
> message.
>
> It is fine to ignore these errors, because the following validate_xxx
> helpers will check the content of the output file, and exit with an
> appropriated error message, e.g. FAIL: File was not generated.
Agreed, the validate functions will catch this and report it more
appropriately.
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
prev parent reply other threads:[~2026-07-13 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 18:04 [PATCH net 0/7] selftests: net: add missing kconfig and settings Matthieu Baerts (NGI0)
2026-07-10 18:04 ` [PATCH net 1/7] selftests: af_unix: add USER_NS config Matthieu Baerts (NGI0)
2026-07-10 18:51 ` Kuniyuki Iwashima
2026-07-10 18:04 ` [PATCH net 2/7] selftests: openvswitch: add config file Matthieu Baerts (NGI0)
2026-07-10 18:04 ` [PATCH net 3/7] selftests: ovpn: add IPV6 and VETH configs Matthieu Baerts (NGI0)
2026-07-13 11:42 ` Antonio Quartulli
2026-07-10 18:04 ` [PATCH net 4/7] selftests: ovpn: increase timeout Matthieu Baerts (NGI0)
2026-07-13 11:44 ` Antonio Quartulli
2026-07-10 18:04 ` [PATCH net 5/7] selftests: drv-net: " Matthieu Baerts (NGI0)
2026-07-10 18:04 ` [PATCH net 6/7] selftests: drv-net: add missing kconfig for psp.py Matthieu Baerts (NGI0)
2026-07-10 21:26 ` Wei Wang
2026-07-10 18:04 ` [PATCH net 7/7] selftests: netconsole: ignore busywait errors Matthieu Baerts (NGI0)
2026-07-13 10:41 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alS6Xdmj-dX2at9z@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox