From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA063C73EA; Mon, 13 Jul 2026 09:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.7 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783935772; cv=fail; b=EMVFyEOWxqOGGXbxZLJVymrZnfQyoPpLaCH1F4OO0uZ21YM3z7Z5hUQ57KK4QFkT38W/bI8YKdy7fIsuerIBDlq0WwbCulA0/s0eJuD+b1pi5lee8l04t0DkgvJNxZxIzqG5GSeTIWkdkelAlT0r5cZ6cks7rgOA+3gK06Yh/gI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783935772; c=relaxed/simple; bh=uQQlBU9oSJ2FpE34B2/Ad8jW3tzmfrIioal32Nk89WM=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=BgLx01pfP09vcRRfU+SuZpOa8tfhEWVuSxda+QJf3jpw1nfzgUJxMGZcpSt2SqLed+xowDmHYb+8X690vllFyRnn6r4fbpekN5SSLepqc0XBMgRBRmzY5ROLC8yquVB3QOQykfniACzLCgjcoVuupHWUTGUJ2m4m+KKRmYiWcjw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XTmUuZou; arc=fail smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XTmUuZou" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783935770; x=1815471770; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=uQQlBU9oSJ2FpE34B2/Ad8jW3tzmfrIioal32Nk89WM=; b=XTmUuZou15bJ7Lofqy7JKuCvFxIzcxJM9q+S4o8QFQ0lUruvmq6JAIpX EDV0BqWm02H459Cf4ccodpAWXDhcCttZsQkGcKkLub6ndGDlHmDFtnue1 I1/i0INKH9SQkxOWSLnuWyvbRZav4YimBiEgQhBXTrcIUSBhPZE5Tc/cN sheO7c5ie3Ym+W21IF4PXUg+hXPFx3jah+ftM1SBXjiI7a+UXU3XIdnes BZtIcR9H6EyJ9INoZQfQV2Y+MX3bw8FSceuKWQ28xVui3ZzonvCorbe2b avcabNMVC5pr81SpJTGB++xlrrX9Z+KJtH79xb3JFVLAJeDjfglOBAlLN w==; X-CSE-ConnectionGUID: jLhyo/tcSouHFyJzRUb/GA== X-CSE-MsgGUID: lj73IRJHRNm+RCBI2hwtVw== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="110083673" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="110083673" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 02:42:48 -0700 X-CSE-ConnectionGUID: JBOaLKHkQFCRgAkbm6a2AQ== X-CSE-MsgGUID: 52Pb8zXaRgO7F8+UtdjifA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="260396788" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 02:42:49 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Mon, 13 Jul 2026 02:42:48 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Mon, 13 Jul 2026 02:42:48 -0700 Received: from SN4PR0501CU005.outbound.protection.outlook.com (40.93.194.51) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Mon, 13 Jul 2026 02:42:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DRk8jLcKQ5Sins0vwc2l9pGNKndqo5FBOVIL50Rg4uu6s57HmI56RcCTt1mR8KRjRkj33A1R3MlxQ3eo0HxQX0y2PK4bzAaSzBLC2rOlbGAq67y3gmZZFfOx2HlzXFcOHGRtTD0H4DmXMe5MuvmS6Uq7N7zQorvCy2R2YWCx2ek56fxyNFpsTolR3llqOG4PyHuBkfh/f6Sf2LyI22+rHC9BkXFiih3BePVoQoLNmsgiVZpGFbJEu3DfBso/+NyBqz4sedg66YIG+4PZ1zfkfMQL4F0YaJqu+0u2IGzMBZxD6IXdMPy/y4/M8dcS8uMtAZAaCvy+d8pIILKmFEk8DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/S8XEEsfSt9lHJOgz4x/muO6ijnCNHJ+tYjU17rH7Yg=; b=iEgA5j/ViLK+iytUpEsVXcEL2OxpZgfWoNNRDvLdRFQJzns88aqIsXQ2A97MScDsB6grIVurT/DLwzgjCDNNB6pn1o3L3vrtAnBe65MlMHdAFXjybzmyovFkb5tC1euijiKVmRlplsBxqR+wm7peAC8sN2IVKMgNl9aGjZVS6rlIMV779e2XToypmnadK94JKHiprqjsE1MC/mmKRIl8W9/6aXvi81V/NAoQw7JwgiUuMj5MnuA3THUC+MOy7re8F5VReP68mGIC0c+sPEg3jXQWez1jOBmaab3/sy/Z7oT0X7CnDH4CtvG3tNvrUhbhshrii8O10/kQGGK3bSTB+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) by DS0PR11MB7580.namprd11.prod.outlook.com (2603:10b6:8:148::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Mon, 13 Jul 2026 09:42:40 +0000 Received: from IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::61e9:afe6:c2c0:722]) by IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::61e9:afe6:c2c0:722%3]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 09:42:39 +0000 Date: Mon, 13 Jul 2026 11:42:34 +0200 From: Maciej Fijalkowski To: David Carlier CC: , , , , , , Subject: Re: [PATCH net] igc: remove napi_synchronize() in igc_down() Message-ID: References: <20260712132242.223254-1-devnexen@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260712132242.223254-1-devnexen@gmail.com> X-ClientProxiedBy: VE1PR03CA0034.eurprd03.prod.outlook.com (2603:10a6:803:118::23) To IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB6097:EE_|DS0PR11MB7580:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bd893a7-ae66-4238-e1c0-08dee0c3144e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: PtPe/lxFYfBw9ZFFB4ZtqR0s7pAMDA21Nn1lB3cydUe2I1ADVv/DJFYV6oh9qf6NAmQItlhp3uYIJ1qgEYOw9aGYZG4jnwngxtC3zsEvwWaGfphvfBMq8Mn2qyD6ufwlgtdGSMuA/f50gVtl2/GV02r4bBETcxxjgnLTGAP8eqp5rPxMqYfoek3gtyOuay7Y8qnAavLUhrrNwVmvLxeA+pYskRuU/Mmypg+9ryJ3CIAhOWzpsXBi7643dD2ifHPgk6lta77E6HFkDt2UmJRp3A/HoPMuITJp7xD0xQW4AxPD4nOaf10C73OZ2YFeMnnu+xjWHA0x4K4Qs0qkdR/jHPGC6SCn8qsVEQoA0/NR4r4ZVp4D+1dl/uc4FIgiLGg3mogugo6baLy9aW+zkKXFhzU7qL8KW+VlUa4VTjvBIeeVBVeFnYvu1GBQkcis1Mn/wn/uoKP2S0RrpeOKtXguUxxrHm55x8IwZPGwOzJJNghEs/v6avE752Dkw/HDFMEVEyc0D2kJx1V4PWSfIry5GkDUzbI7ehMLVu4J1GGzXmba0q2JOKWmsVkEUWSkb6iS37fzRjGDaomyWmfJlNxwt2BUW5XCpd/Y93akGbIu1FGoRLVVM45dUcmg5dtirwYu82GpeGlssqkk8XKqj3hTivEUZb17ZiL6o9PJ9RBfPpg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6097.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QCDqx3M5lhcnbKSz5laPoHJOHPMwMuXVmzvSdZYtRZlLOOstLWdMcre5yFXD?= =?us-ascii?Q?DTCvEfcNbztzN8QgV3QgEP/Bg+/0vTyufZn40zK+nfWVjvhnFaiNvW5IztBI?= =?us-ascii?Q?uJiUUbLwe+umoxT4hZFWZZgQncFTZ8LU59WX2kmuDO82Fmr5H5GPyBMCdQno?= =?us-ascii?Q?zpilXGI8gVY6jClgEYKppzQViSQXq/7OVPknU/jVO1wUKTlr58UNWZYSMicv?= =?us-ascii?Q?+oiArN0O72Yeju01Fj+eW+SyuaPkrS4C+MWlE2ETwufivqm7IJX5dBi7xf9G?= =?us-ascii?Q?f66tsUrNc2Kwvr/v0Tk9W3qNL8QvOnWzTThy3tdyaqP1QzFcHHFxxhMJGCxT?= =?us-ascii?Q?4iY48wQFoMURz94ixqsGledYFekYCz+ZdiY2VikbgYw8L4/kZiN5XRCea9Uh?= =?us-ascii?Q?AgpViHz4llWA/jAmTQFR2h7+N19xvO0ePDL0sTBcseUf8vAbNzckXqKxrv7p?= =?us-ascii?Q?wyN29tE74p0Dy0uAtynD1FSpLun6hoMcJ7tJUvCJgT2fU4eCCvCzS6SQ6RaJ?= =?us-ascii?Q?y9XqADJQfJ3WpB2px5pafiK/kyD+YADcIZJmWDaqW/I0IPp/s4p4GuaMPN7b?= =?us-ascii?Q?3ja/1nBtMlC8EczqAYSdwK0SXaJOPvvguTr3daaRNT9eQcjIM/eXgyaaFuGA?= =?us-ascii?Q?L6DZVDMbWDgqksCSD82ovHqHJTX+1gSJqnoK8TBwy7BDmoUjY8Au2Inbq4N8?= =?us-ascii?Q?YlUQQ5VX/K4B66Y5lxITwA8EEB/KqBw+Bj9r+x4L3BupLX4SwclWUzgSUB3A?= =?us-ascii?Q?RkIhtizUBmlHx9+n5s8qxoPtxFZ4qRiBN8OsXdXtyhaizNvOky4GVxXHrvkd?= =?us-ascii?Q?X/SjSTee03256NLmrgN3uLv4EZTv1Vegh0q+YkRkRclF8/tamCwWunZqn5qF?= =?us-ascii?Q?hsH+3CPJkKYSKfbTjsf9aYYPIbvq51FfNCbvOZeNLx+X2Juk9WnP4hdK+2ZV?= =?us-ascii?Q?9mHH6xa7YWYG+XxzxCC1teXmAwA3PNZNLodgJxfbk8ZyT0paYjJznLQgtA7y?= =?us-ascii?Q?IDrHAW89NJYNQw4Hr3Yc6KPaSS5RnKdn5ofFQtMFbwNdYXavVTSHEj9p/avP?= =?us-ascii?Q?B+eWwVxqxXWAbBdV/T4IpOEOmkrZXjj+W0f9GIN12SlU0oFpTlZ/00tV0KOa?= =?us-ascii?Q?eKpey7zApwSa5LKWcpWewlag5OdO25TIwBXQhCjRsT8N2mHZVOGNLUXGpi5Q?= =?us-ascii?Q?a+ntGp7/5IUq1Uap4qM0b5Y430ak+qN8BLAJLEuywS9omRqFt1VCsLmYuBwd?= =?us-ascii?Q?hemflNFIG808hENFwtl45bCf1lwqVK4XDHHPfdQjmwTGj5meBwEZlrjj6CiL?= =?us-ascii?Q?ByAAV8lrITDbJAesJGXhAOddEgXS0gomAOlzgTt+wSnLUwr0J4ILs4KZ0Epp?= =?us-ascii?Q?zhLtZbYnjUPKQEsJ4Q5Sk0LPSeT+Gr7h6PLl7uCnPDhX26RmoaN+atuQhWM+?= =?us-ascii?Q?35I5yKz7xWVNNQiNGN1mn/Yj8EinlWWqcHPEDH5gnKWEAbhBeXSMaKJfDCMQ?= =?us-ascii?Q?GVjiHxEKid6CgrIxVAMlYhiX0VbF0Yq8ngVVlSFhF9VnW/wzS52coE19Qvbp?= =?us-ascii?Q?996wxt+vFr3gbR5PEZFl77rxiI+IIslosUVqUqnH6+Gf9jfiNE+dILV6CMYy?= =?us-ascii?Q?Svxyc9i9GESypuDHajABu/BdreawrYPyoEme9+5rQRvp+Ml5uX8vPl+AcTP8?= =?us-ascii?Q?RELm6jk3T1QkjDmuYfSf62RsWSvC69l2aWJ7dqg6r5F/M1J1CWZMSREfacae?= =?us-ascii?Q?u/5TPL8vm6ulfrvaGmvQhua3O9PZhYI=3D?= X-Exchange-RoutingPolicyChecked: CYKUlBvIMtaJWMNeCvV8NjimoLyY9fSjna1IJekUXlJ1E/rCsUZWsWPoQYyBO4MxAUkgBKUXDFeQfhue351Qa4WhjwbWTUfnxbbxhKHUQh0eB8BfiFvGw6yNtiQp1zm6OsX+2iMawRxcQJfah3QY0Iv23p5c0yETxM7Az3G3Lr0LnOzwSwHoNXlvFBXqunZrq0wMrP2eQHFkreLADq3sm5ccVWw+HmLvIHwRRUJdLX2tqo8XeauFOJw3MiUtqgHHrTaITMBUyj8qWKbMz08VRfGlz61oPKXqL+aLZ3+uGyeqTI0o1HLWkcw5sFtJFlI01oqHBJnXgcZYPD/c1NzyzQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 9bd893a7-ae66-4238-e1c0-08dee0c3144e X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 09:42:39.8235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZxGYCCpi5ME/d7tqXkey9VL4Ef7WEIPkWcOB0x9fEc+N3/ZJF8DdgXp5J3CcbQSUBZhUfn2/a7/7CKKMCPqA6EIWLqxugbsCAFRZ4t050Go= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7580 X-OriginatorOrg: intel.com On Sun, Jul 12, 2026 at 02:22:42PM +0100, David Carlier wrote: > When an AF_XDP zero-copy application is killed abruptly, the XSK pool is > torn down but NAPI keeps polling. igc_clean_rx_irq_zc() then returns the > full budget on every poll, so napi_complete_done() never clears > NAPI_STATE_SCHED. > > igc_down() calls napi_synchronize() before napi_disable(), so it spins > forever waiting for that bit and the interface never goes down. Drop the > napi_synchronize() and let napi_disable() do the job -- it sets > NAPI_STATE_DISABLE, which forces the stuck poll to complete. Reorder it > ahead of igc_set_queue_napi() so the NAPI mapping is cleared only after > polling has stopped, matching the recent igb fix b1e067240379. > > Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy") > Suggested-by: Maciej Fijalkowski > Cc: stable@vger.kernel.org > Signed-off-by: David Carlier Reviewed-by: Maciej Fijalkowski This is a mirror of what Alex Dvoretsky did on igb, correct? Did you reproduce the same issue on your side or is it a blind shot at this driver? Regardless, I think it's a correct thing to do, but some clarification would be nice. > --- > drivers/net/ethernet/intel/igc/igc_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index 2c9e2dfd8499..b3883a5a7d7a 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -5352,9 +5352,8 @@ void igc_down(struct igc_adapter *adapter) > > for (i = 0; i < adapter->num_q_vectors; i++) { > if (adapter->q_vector[i]) { > - napi_synchronize(&adapter->q_vector[i]->napi); > - igc_set_queue_napi(adapter, i, NULL); > napi_disable(&adapter->q_vector[i]->napi); > + igc_set_queue_napi(adapter, i, NULL); > } > } > > -- > 2.53.0 >