Re: [PATCH net-next v4 00/15][pull request] Introduce iXD driver

[Larysa Zaremba <larysa.zaremba@intel.com>]

I have addressed Sashiko's feedback for each patch.

Those are the only 2 important changes that came out of that. 
Please, notice that the first one is not a functional regression, but a memory 
usage issue and I tested the change.

commit d7a772efb77228a1b12558dced6b1fdfeef123c4
Author: Larysa Zaremba <larysa.zaremba@intel.com>
Date:   Mon Jul 13 17:02:01 2026 +0200

    fixup! libie: add bookkeeping support for control queue messages

diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c
index c043c07dbb89..8e7b2783b86b 100644
--- a/drivers/net/ethernet/intel/libie/controlq.c
+++ b/drivers/net/ethernet/intel/libie/controlq.c
@@ -720,7 +720,7 @@ static int libie_ctlq_xn_init_dma(struct device *dev,
                        goto dealloc_dma;

                dma_mem->va = libie_cp_alloc_dma_mem(dev, dma_mem,
-                                                    LIBIE_CTLQ_MAX_BUF_LEN);
+                                                    LIBIE_CP_TX_COPYBREAK);
                if (!dma_mem->va) {
                        kfree(dma_mem);
                        goto dealloc_dma;


commit 740e3b2dc9fab1ad24ee7fa1420d0c7025bc89ac
Author: Larysa Zaremba <larysa.zaremba@intel.com>
Date:   Mon Jul 13 20:25:21 2026 +0200

    fixup! libie: add control queue support

diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c
index 0392608856c8..c043c07dbb89 100644
--- a/drivers/net/ethernet/intel/libie/controlq.c
+++ b/drivers/net/ethernet/intel/libie/controlq.c
@@ -509,6 +509,7 @@ void libie_ctlq_send(struct libie_ctlq_info *ctlq, u32 num_q_msg)
                if (unlikely(++ntu == ctlq->ring_len))
                        ntu = 0;
        }
+       dma_wmb();
        writel(ntu, ctlq->reg.tail);
        ctlq->next_to_use = ntu;
 }



Other changes are of much lesser importance. Look at particular patches for 
details on nice-to-haves and false positives. Here is overall nice-to-have diff:

diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c b/drivers/net/ethernet/intel/idpf/idpf_main.c
index 5a191644b28e..184d30c12abb 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_main.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_main.c
@@ -265,8 +265,9 @@ static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)

        err = idpf_dev_init(adapter, ent);
        if (err) {
-               dev_err(&pdev->dev, "Unexpected dev ID 0x%x in idpf probe\n",
-                       ent->device);
+               dev_err(&pdev->dev,
+                       "Failed to initialize device (ID 0x%x): %d\n",
+                       ent->device, err);
                goto err_free;
        }

diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
index 04a0421c1b77..d768b63700c8 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
@@ -2931,6 +2931,8 @@ int idpf_init_dflt_mbx(struct idpf_adapter *adapter)
        adapter->arq = libie_find_ctlq(ctx, LIBIE_CTLQ_TYPE_RX,
                                       LIBIE_CTLQ_MBX_ID);
        if (!adapter->asq || !adapter->arq) {
+               adapter->asq = NULL;
+               adapter->arq = NULL;
                libie_ctlq_xn_deinit(params.xnm, ctx);
                return -ENOENT;
        }
@@ -3993,7 +3995,7 @@ int idpf_set_promiscuous(struct idpf_adapter *adapter,
  * @send_msg: message to send
  * @msg_size: size of message to send
  * @recv_msg: message to populate on reception of response
- * @recv_len: length of message copied into recv_msg or 0 on error
+ * @recv_len: length of message copied into recv_msg
  *
  * Return: 0 on success or error code on failure.
  */
diff --git a/drivers/net/ethernet/intel/ixd/ixd_virtchnl.c b/drivers/net/ethernet/intel/ixd/ixd_virtchnl.c
index 66049d1b1d15..5b04769443b9 100644
--- a/drivers/net/ethernet/intel/ixd/ixd_virtchnl.c
+++ b/drivers/net/ethernet/intel/ixd/ixd_virtchnl.c
@@ -120,8 +120,11 @@ static int ixd_handle_vc_ver(struct ixd_adapter *adapter, void *recv_buff,
                return -EBADMSG;

        recv_ver = recv_buff;
-       if (le32_to_cpu(need_ver.major) > le32_to_cpu(recv_ver->major))
+       if (le32_to_cpu(need_ver.major) != le32_to_cpu(recv_ver->major))
                return -EOPNOTSUPP;
+       if (le32_to_cpu(recv_ver->minor) != le32_to_cpu(need_ver.minor))
+               dev_warn(ixd_to_dev(adapter),
+                        "Virtchnl minor version does not match, proceed with caution\n");

        adapter->vc_ver.major = le32_to_cpu(recv_ver->major);
        adapter->vc_ver.minor = le32_to_cpu(recv_ver->minor);
diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c
index 885b4437b4f0..8e7b2783b86b 100644
--- a/drivers/net/ethernet/intel/libie/controlq.c
+++ b/drivers/net/ethernet/intel/libie/controlq.c
@@ -327,7 +327,8 @@ libie_ctlq_add(struct libie_ctlq_ctx *ctx,
 {
        struct libie_ctlq_info *ctlq;

-       if (qinfo->id != LIBIE_CTLQ_MBX_ID)
+       if (qinfo->id != LIBIE_CTLQ_MBX_ID ||
+           qinfo->len > FIELD_MAX(LIBIE_CTLQ_MBX_ATQ_LEN))
                return ERR_PTR(-EOPNOTSUPP);

        /* libie_ctlq_init was not called */
@@ -493,8 +494,6 @@ EXPORT_SYMBOL_NS_GPL(libie_ctlq_send_desc_avail, "LIBIE_CP");
  * The caller must hold ctlq->lock. The intended pattern is to first check
  * the number of descriptors available, then fill in the messages and perform
  * send within a single critical section.
- *
- * Return: %0 on success, -%errno on failure.
  */
 void libie_ctlq_send(struct libie_ctlq_info *ctlq, u32 num_q_msg)
 {