From: Breno Leitao <leitao@debian.org>
To: Doruk Tan Ozturk <doruk@0sec.ai>
Cc: alex.aring@gmail.com, stefan@datenfreihafen.org,
miquel.raynal@bootlin.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, phoebe.buckheister@itwm.fraunhofer.de,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] mac802154: llsec: reject frames shorter than the authentication tag
Date: Thu, 16 Jul 2026 06:23:56 -0700 [thread overview]
Message-ID: <aljbEr7K3uVRjJNT@gmail.com> (raw)
In-Reply-To: <20260709131246.44517-1-doruk@0sec.ai>
On Thu, Jul 09, 2026 at 03:12:46PM +0200, Doruk Tan Ozturk wrote:
> Reported-by: Doruk Tan Ozturk <doruk@0sec.ai>
> Signed-off-by: Doruk Tan Ozturk <doruk@0sec.ai>
Usually you don't have Reported-by if you are fixing something yourself.
> ---
> net/mac802154/llsec.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/mac802154/llsec.c b/net/mac802154/llsec.c
> index 5e7cc11fab3a..364a1ac1d771 100644
> --- a/net/mac802154/llsec.c
> +++ b/net/mac802154/llsec.c
> @@ -893,6 +893,11 @@ llsec_do_decrypt_auth(struct sk_buff *skb, const struct mac802154_llsec *sec,
Why not returning here, before sg_init_one()? here you alrady have
datalen and authlen.
> sg_init_one(&sg, skb_mac_header(skb), assoclen + datalen);
>
> + if (datalen < authlen) {
> + kfree_sensitive(req);
> + return -EBADMSG;
> + }
> +
> if (!(hdr->sec.level & IEEE802154_SCF_SECLEVEL_ENC)) {
> assoclen += datalen - authlen;
> datalen = authlen;
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2026-07-16 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 13:12 [PATCH net] mac802154: llsec: reject frames shorter than the authentication tag Doruk Tan Ozturk
2026-07-16 10:09 ` Simon Horman
2026-07-16 13:23 ` Breno Leitao [this message]
2026-07-16 19:31 ` Doruk Tan Ozturk
2026-07-16 19:31 ` [PATCH net v2] " Doruk Tan Ozturk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aljbEr7K3uVRjJNT@gmail.com \
--to=leitao@debian.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=doruk@0sec.ai \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phoebe.buckheister@itwm.fraunhofer.de \
--cc=stable@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox