From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petko Manolov Subject: Re: [PATCH 24/77] usbnet: convert rtl driver to net_device_ops Date: Mon, 23 Mar 2009 11:17:14 +0200 (EET) Message-ID: References: <20090321053527.316395697@vyatta.com> <20090321053714.361988448@vyatta.com> <200903210203.43124.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Stephen Hemminger , David Miller , netdev@vger.kernel.org, Petko Manolov To: David Brownell Return-path: Received: from lan.nucleusys.com ([78.83.248.164]:37818 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755286AbZCWJ5i (ORCPT ); Mon, 23 Mar 2009 05:57:38 -0400 In-Reply-To: <200903210203.43124.david-b@pacbell.net> Sender: netdev-owner@vger.kernel.org List-ID: ACK :-) cheers, Petko On Sat, 21 Mar 2009, David Brownell wrote: > On Friday 20 March 2009, Stephen Hemminger wrote: >> Signed-off-by: Stephen Hemminger > > cc'd the maintainer ... by the way, note that > "usbnet" != "everything in drivers/net/usb" ... > > >> --- a/drivers/net/usb/rtl8150.c 2009-03-20 12:12:47.085715442 -0700 >> +++ b/drivers/net/usb/rtl8150.c 2009-03-20 12:13:41.757841762 -0700 >> @@ -891,6 +891,19 @@ static int rtl8150_ioctl(struct net_devi >> return res; >> } >> >> +static const struct net_device_ops rtl8150_netdev_ops = { >> + .ndo_open = rtl8150_open, >> + .ndo_stop = rtl8150_close, >> + .ndo_do_ioctl = rtl8150_ioctl, >> + .ndo_start_xmit = rtl8150_start_xmit, >> + .ndo_tx_timeout = rtl8150_tx_timeout, >> + .ndo_set_multicast_list = rtl8150_set_multicast, >> + .ndo_set_mac_address = rtl8150_set_mac_address, >> + >> + .ndo_change_mtu = eth_change_mtu, >> + .ndo_validate_addr = eth_validate_addr, >> +}; >> + >> static int rtl8150_probe(struct usb_interface *intf, >> const struct usb_device_id *id) >> { >> @@ -917,15 +930,8 @@ static int rtl8150_probe(struct usb_inte >> >> dev->udev = udev; >> dev->netdev = netdev; >> - netdev->open = rtl8150_open; >> - netdev->stop = rtl8150_close; >> - netdev->do_ioctl = rtl8150_ioctl; >> + netdev->netdev_ops = &rtl8150_netdev_ops; >> netdev->watchdog_timeo = RTL8150_TX_TIMEOUT; >> - netdev->tx_timeout = rtl8150_tx_timeout; >> - netdev->hard_start_xmit = rtl8150_start_xmit; >> - netdev->set_multicast_list = rtl8150_set_multicast; >> - netdev->set_mac_address = rtl8150_set_mac_address; >> - >> SET_ETHTOOL_OPS(netdev, &ops); >> dev->intr_interval = 100; /* 100ms */ >> >> >> -- >> >> > > >