From: Dan Carpenter <error27@gmail.com>
To: vbordug@ru.mvista.com, avorontsov@ru.mvista.com
Cc: netdev@vger.kernel.org
Subject: [patch] error handling for platform_device_register_simple()
Date: Thu, 9 Apr 2009 10:55:29 +0300 (EAT) [thread overview]
Message-ID: <alpine.DEB.2.00.0904090640170.13970@bicker> (raw)
platform_device_register_simple() returns ERR_PTR() and not NULL.
Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/net/phy/fixed.c 2009-04-09 05:53:24.000000000 +0300
+++ devel/drivers/net/phy/fixed.c 2009-04-09 05:53:52.000000000 +0300
@@ -207,8 +207,8 @@
int ret;
pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
- if (!pdev) {
- ret = -ENOMEM;
+ if (IS_ERR(pdev)) {
+ ret = PTR_ERR(pdev);
goto err_pdev;
}
reply other threads:[~2009-04-09 7:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0904090640170.13970@bicker \
--to=error27@gmail.com \
--cc=avorontsov@ru.mvista.com \
--cc=netdev@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox