From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: netdev@vger.kernel.org
Subject: a couple questions about drivers/net/macv*.c
Date: Sat, 10 Jul 2010 19:44:59 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1007101652030.7658@lynx> (raw)
first (trivial) point, i notice that both macvlan.c and macvtap.c
are still both listed as EXPERIMENTAL -- is that still accurate?
bigger issue in macvtap.c -- notice this declaration:
static unsigned int macvtap_major;
that seems like a violation of coding style since that variable is
used later on in:
devt = MKDEV(MAJOR(macvtap_major), dev->ifindex);
and
err = alloc_chrdev_region(&macvtap_major, 0,
MACVTAP_NUM_DEVS, "macvtap");
where its type should simply be the typedef "dev_t" for transparency,
should it not? hardcoding that variable as an unsigned int seems like
a bad idea.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Top-notch, inexpensive online Linux/OSS/kernel courses
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next reply other threads:[~2010-07-11 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 23:44 Robert P. J. Day [this message]
2010-07-11 2:26 ` a couple questions about drivers/net/macv*.c David Miller
2010-07-11 2:31 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1007101652030.7658@lynx \
--to=rpjday@crashcourse.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox