From: Christoph Lameter <cl@linux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH] atomic: add atomic_inc_not_zero_hint()
Date: Mon, 15 Nov 2010 08:25:37 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1011150821000.19175@router.home> (raw)
In-Reply-To: <1289830636.2607.70.camel@edumazet-laptop>
On Mon, 15 Nov 2010, Eric Dumazet wrote:
> Exclusive access ? As soon as another cpu takes it again, you lose.
Sure but you want to avoid the fetch in shared mode here.
> Its not really the same thing... Maybe you miss the 'hint' intention at
> all. We know the probable value of the counter, we dont want to read it.
Ok may be in thise case you can predict the value but in general it is
difficult to always provide an expected value. It would be easier to be
able to tell the processor that the cacheline should not be fetched as
shared but immediately in exclusive state.
> atomic_read() and atomic_cmpxchg(). We tried prefetchw() and it was a
> performance drop. It was with only 16 cpus contending on neighbour
Does prefetchw work? Andi claims that prefetchw is not working on
x86 and I doubt that you ran tests on Itanium.
next prev parent reply other threads:[~2010-11-15 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 16:53 [PATCH] atomic: add atomic_inc_not_zero_hint() Eric Dumazet
2010-11-05 17:20 ` Andrew Morton
2010-11-05 18:00 ` Eric Dumazet
2010-11-05 18:08 ` Andrew Morton
2010-11-05 18:20 ` Eric Dumazet
2010-11-05 18:28 ` Andrew Morton
2010-11-05 19:20 ` Eric Dumazet
2010-11-05 19:39 ` Andrew Morton
2010-11-05 19:46 ` Eric Dumazet
2010-11-05 19:51 ` Paul E. McKenney
2010-11-12 19:14 ` Christoph Lameter
2010-11-13 22:26 ` Paul E. McKenney
2010-11-15 13:57 ` Christoph Lameter
2010-11-15 14:07 ` Andi Kleen
2010-11-15 14:16 ` Christoph Lameter
2010-11-15 14:17 ` Eric Dumazet
2010-11-15 14:25 ` Christoph Lameter [this message]
2010-11-15 14:39 ` Andi Kleen
2010-11-15 14:47 ` Eric Dumazet
2010-11-05 18:40 ` Paul E. McKenney
2010-11-05 19:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1011150821000.19175@router.home \
--to=cl@linux.com \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).