From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [Bugme-new] [Bug 33502] New: Caught 64-bit read from uninitialized memory in __alloc_skb Date: Mon, 9 May 2011 22:44:18 +0300 (EEST) Message-ID: References: <20110418153852.153d3ed3.akpm@linux-foundation.org> <1303181466.4152.39.camel@edumazet-laptop> <1303182557.4152.48.camel@edumazet-laptop> <1303183217.4152.49.camel@edumazet-laptop> <1303244270.2756.3.camel@edumazet-laptop> <4DAE7579.3020400@cs.helsinki.fi> <1303279470.2756.17.camel@edumazet-laptop> <1303285519.4dae8f0fdf9b1@imp.free.fr> <4DAE901C.2090809@cs.helsinki.fi> <1303286998.3186.18.camel@edumazet-laptop> <1303290464.3186.32.camel@edumazet-laptop> <1303293765.3186.74.camel@edumazet-laptop> <1303309591.3186.84.camel@edumazet-laptop> <1303311687.3186.100.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Christoph Lameter , Pekka Enberg , casteyde.christian@free.fr, Andrew Morton , netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org, Vegard Nossum To: Eric Dumazet Return-path: Received: from filtteri1.pp.htv.fi ([213.243.153.184]:58808 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754120Ab1EIToU (ORCPT ); Mon, 9 May 2011 15:44:20 -0400 In-Reply-To: <1303311687.3186.100.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Apr 2011, Eric Dumazet wrote: > [PATCH v4] slub: dont use cmpxchg_double if KMEMCHECK or DEBUG_PAGEALLOC > > Christian Casteyde reported a KMEMCHECK splat in slub code. > > Problem is now we are lockless and allow IRQ in slab_alloc(), the object > we manipulate from freelist can be allocated and freed right before we > try to read object->next. > > Same problem can happen with DEBUG_PAGEALLOC > > Just dont use cmpxchg_double() if either CONFIG_KMEMCHECK or > CONFIG_DEBUG_PAGEALLOC is defined. Christoph, Eric, is this still relevant after commit 1759415 ("slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery") in slab/next of slab.git? Pekka