From: Petko Manolov <petkan@nucleusys.com>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-usb@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Active URB submitted twice in pegasus driver
Date: Tue, 26 Mar 2013 22:54:25 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.02.1303262247490.3959@fry> (raw)
In-Reply-To: <20130326185218.GD10317@xanatos>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 343 bytes --]
On Tue, 26 Mar 2013, Sarah Sharp wrote:
> But considering the multicast code is pretty old, I bet I'm running into
> a different bug...
The fix is rather small. Approximately one gigabyte was transferred while
alternating in and out of promiscuous mode. No issues.
I guess this should move the driver out of the equation.
cheers,
Petko
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: TEXT/x-diff; name=pegasus.diff, Size: 422 bytes --]
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index 73051d1..879da39 100644
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -1220,8 +1220,6 @@ static void pegasus_set_multicast(struct net_device *net)
pegasus->eth_regs[EthCtrl2] &= ~RX_PROMISCUOUS;
}
- pegasus->ctrl_urb->status = 0;
-
pegasus->flags |= ETH_REGS_CHANGE;
ctrl_callback(pegasus->ctrl_urb);
}
next prev parent reply other threads:[~2013-03-26 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 22:38 Active URB submitted twice in pegasus driver Sarah Sharp
2013-03-26 15:22 ` Petko Manolov
2013-03-26 17:01 ` Sarah Sharp
2013-03-26 17:28 ` Petko Manolov
2013-03-26 18:52 ` Sarah Sharp
2013-03-26 20:54 ` Petko Manolov [this message]
2013-03-26 21:37 ` Sarah Sharp
2013-03-26 22:26 ` Petko Manolov
2013-04-05 17:01 ` Petko Manolov
2013-04-08 15:49 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1303262247490.3959@fry \
--to=petkan@nucleusys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox