From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN Date: Thu, 3 Oct 2013 07:41:27 +0200 (CEST) Message-ID: References: <1380679480.2081.24.camel@joe-AO722> <87k3hw469z.fsf@kamboji.qca.qualcomm.com> <1380696054.2081.35.camel@joe-AO722> <1380736969.2081.72.camel@joe-AO722> <1380758954.2081.79.camel@joe-AO722> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Luis R. Rodriguez" , Kalle Valo , netdev , ath10k@lists.infradead.org To: Joe Perches Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:9886 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877Ab3JCFle (ORCPT ); Thu, 3 Oct 2013 01:41:34 -0400 In-Reply-To: <1380758954.2081.79.camel@joe-AO722> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2 Oct 2013, Joe Perches wrote: > On Thu, 2013-10-03 at 00:38 +0200, Julia Lawall wrote: > > > > > > On Wed, 2 Oct 2013, Joe Perches wrote: > > > > > On Wed, 2013-10-02 at 10:44 -0700, Luis R. Rodriguez wrote: > > > > On Tue, Oct 1, 2013 at 11:40 PM, Joe Perches wrote: > > > > > Please include netdev. (cc'd) > > > > > > > > > >> Joe Perches writes: > > > > >> > > > > >> > Convert the memset/memcpy uses of 6 to ETH_ALEN > > > > >> > where appropriate. > > > > > > > > > >> > Signed-off-by: Joe Perches > > > > > > > > I think these sorts of patches are good -- but once applied it'd be > > > > good if we can get the SmPL grammar expressed for it and then have > > > > developers / maintainers regularly doing: > > > > > > > > make coccicheck MODE=patch M=path > path-cocci.patch > > > > > > > > Unfortunately right now MODE=patch takes about 3 1/2 minutes for > > > > ath9k, MODE=org takes ~10 minutes for ath9k (17 minutes for all of > > > > ath/), and MODE=context takes ~8 minutes on ath9k -- I do believe its > > > > a bit unreasonable to expect patch submitters to use this, but > > > > certainly great practice. Some of the time differences on the reports > > > > can be explained by the fact that some SmPL will only be used for some > > > > modes. > > > > > > > > Even though it takes a while right now it'd be great practice to use > > > > coccicheck to prevent these type of changes from going in again, > > > > things that checkpatch.pl won't be able to catch. > > > > > > As far as I can tell, it's basically not possible for cocci to > > > do this conversion. > > > > I tried looking for memcpys and memsets that do use ETH_ALEN and then > > seeing what non-local functions the affected values flow to. I then > > marked all of the calls to memcpy and memset that use 6 where an affected > > value flows to one of the functions identified in the first pass. I get > > 40 unique results on Linux 3.10. > > > > The semantic patch is below. It needs to be cleaned up to not return > > duplicate results. It needs to be run with the argument --no-show-diff, > > and the result is printed in emacs org mode. > > This has been running a _long_ time (broken?) on > drivers/net/ethernet/mellanox/mlx4/en_netdev.c > > $ spatch --version > spatch version 1.0.0-rc14 without Python support and with PCRE support Likewise. I can look at it, but generally I just use a timeout. Note that you should run it on a whole directory, not on a file at a time, so that it can collectthe most possible information on the first pass. julia