From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN Date: Thu, 3 Oct 2013 07:43:23 +0200 (CEST) Message-ID: References: <1380679480.2081.24.camel@joe-AO722> <87k3hw469z.fsf@kamboji.qca.qualcomm.com> <1380696054.2081.35.camel@joe-AO722> <1380736969.2081.72.camel@joe-AO722> <1380758954.2081.79.camel@joe-AO722> <1380760114.2081.81.camel@joe-AO722> <1380771110.2081.89.camel@joe-AO722> <1380771551.2081.93.camel@joe-AO722> <1380773924.19002.131.camel@edumazet-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Joe Perches , Kalle Valo , "Luis R. Rodriguez" , netdev , ath10k@lists.infradead.org, "John W. Linville" To: Eric Dumazet Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:53081 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754795Ab3JCFnZ (ORCPT ); Thu, 3 Oct 2013 01:43:25 -0400 In-Reply-To: <1380773924.19002.131.camel@edumazet-glaptop.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2 Oct 2013, Eric Dumazet wrote: > On Wed, 2013-10-02 at 20:39 -0700, Joe Perches wrote: > > Use the appropriate define instead of 6. > > > > Signed-off-by: Joe Perches > > Noticed-by: Julia Lawall via spatch script > > > > --- > > > > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > > index bee88e8..48d44e7 100644 > > --- a/drivers/net/wireless/ath/ath10k/wmi.c > > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > > @@ -1758,7 +1758,7 @@ int ath10k_wmi_vdev_up(struct ath10k *ar, u32 vdev_id, u32 aid, const u8 *bssid) > > cmd = (struct wmi_vdev_up_cmd *)skb->data; > > cmd->vdev_id = __cpu_to_le32(vdev_id); > > cmd->vdev_assoc_id = __cpu_to_le32(aid); > > - memcpy(&cmd->vdev_bssid.addr, bssid, 6); > > + memcpy(&cmd->vdev_bssid.addr, bssid, ETH_ALEN); > > > > ath10k_dbg(ATH10K_DBG_WMI, > > "wmi mgmt vdev up id 0x%x assoc id %d bssid %pM\n", > > I don't get it. > > Why leaving this then ? > > struct wmi_mac_addr { > union { > u8 addr[6]; > struct { > u32 word0; > u32 word1; > } __packed; > } __packed; > } __packed; Yes, this was step 2... julia