From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN Date: Thu, 3 Oct 2013 07:47:49 +0200 (CEST) Message-ID: References: <1380679480.2081.24.camel@joe-AO722> <87k3hw469z.fsf@kamboji.qca.qualcomm.com> <1380696054.2081.35.camel@joe-AO722> <1380736969.2081.72.camel@joe-AO722> <1380758954.2081.79.camel@joe-AO722> <1380760114.2081.81.camel@joe-AO722> <1380771110.2081.89.camel@joe-AO722> <1380771551.2081.93.camel@joe-AO722> <1380773924.19002.131.camel@edumazet-glaptop.roam.corp.google.com> <87fvsjynuk.fsf@kamboji.qca.qualcomm.com> <1380775478.19002.139.camel@edumazet-glaptop.roam.corp.google.com> <1380776994.2081.101.camel@joe-AO722> <1380777884.19002.155.camel@edumazet-glaptop.roam.corp.google.com> <1380778451.2081.103.camel@joe-AO722> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Eric Dumazet , Kalle Valo , "Luis R. Rodriguez" , netdev , ath10k@lists.infradead.org, "John W. Linville" To: Joe Perches Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:17539 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753673Ab3JCFrv (ORCPT ); Thu, 3 Oct 2013 01:47:51 -0400 In-Reply-To: <1380778451.2081.103.camel@joe-AO722> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2 Oct 2013, Joe Perches wrote: > On Wed, 2013-10-02 at 22:24 -0700, Eric Dumazet wrote: > > On Wed, 2013-10-02 at 22:09 -0700, Joe Perches wrote: > > > On Wed, 2013-10-02 at 21:44 -0700, Eric Dumazet wrote: > > > > I mean the 6, of course, since Joe seems to actively track them, as if > > > > ETH_ALEN could change eventually, you never know. > > > > > > You're funny Eric. > > > You know it's just to ease grep pattern matching. > > > > You are not funny if you plan to send 500+ patches for every instance of > > 6 changed to ETH_ALEN > > You're still funny. > > https://lkml.org/lkml/2013/10/1/517 > > Lighten up though. It was just a straggler. Actually, the few cases that I looked up by hand seemed to use 6 consistently for the declaration and the memcpy/memset. So it would be nicer to fix them all at once. At least in drivers/net there are around 40, not 500. julia