From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare Date: Thu, 2 Jan 2014 09:38:12 +0100 (CET) Message-ID: References: <52C4BD16.5010702@huawei.com> <52C52180.2030707@huawei.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1867944953-1388651893=:2182" Cc: Julia Lawall , Joe Perches , Jay Vosburgh , Veaceslav Falico , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" To: Ding Tianhong Return-path: In-Reply-To: <52C52180.2030707@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1867944953-1388651893=:2182 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 2 Jan 2014, Ding Tianhong wrote: > On 2014/1/2 15:39, Julia Lawall wrote: > > Are the casts needed > > > Yes, otherwise the warming will report: > > /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing argument 1 of ‘ether_addr_equal_64bits’ from incompatible pointer type Is it necessary for this driver to use a different type from everyone else? julia --8323328-1867944953-1388651893=:2182--