From: dormando <dormando@rydia.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Alexey Preobrazhensky" <preobr@google.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"David Miller" <davem@davemloft.net>,
paulmck@linux.vnet.ibm.com, netdev@vger.kernel.org,
"Kostya Serebryany" <kcc@google.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Lars Bull" <larsbull@google.com>,
"Eric Dumazet" <edumazet@google.com>,
"Bruce Curtis" <brutus@google.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH] ipv4: fix a race in ip4_datagram_release_cb()
Date: Sat, 28 Jun 2014 17:25:38 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1406281724370.18954@dtop> (raw)
In-Reply-To: <1402450009.3645.444.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, 10 Jun 2014, Eric Dumazet wrote:
> On Tue, 2014-06-10 at 18:12 -0700, Eric Dumazet wrote:
>
> >
> > For the curious, another problem is in ipv4_sk_update_pmtu()
> >
> > This can be called on UDP sockets, but from softirq context.
> >
> > We cannot use sk_dst_lock because this lock is not softirq safe.
> >
> > I guess we should use xchg() for sk_dst_set() and sk_dst_reset()
>
> This would be something like this untested patch :
>
I see this didn't get queued for stable, should it be dropped due to the
later patch? (which did get queued for stable).
next prev parent reply other threads:[~2014-06-29 0:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 11:29 Potential race in ip4_datagram_release_cb Alexey Preobrazhensky
2014-06-06 12:56 ` Eric Dumazet
2014-06-06 15:59 ` Alexei Starovoitov
2014-06-06 16:16 ` Eric Dumazet
2014-06-06 17:44 ` Alexei Starovoitov
2014-06-06 17:56 ` Eric Dumazet
2014-06-06 18:13 ` Alexei Starovoitov
2014-06-10 13:43 ` [PATCH] ipv4: fix a race in ip4_datagram_release_cb() Eric Dumazet
2014-06-11 0:32 ` dormando
2014-06-11 0:55 ` Eric Dumazet
2014-06-11 1:12 ` Eric Dumazet
2014-06-11 1:26 ` Eric Dumazet
2014-06-11 4:16 ` dormando
2014-06-11 5:54 ` Eric Dumazet
2014-06-11 7:20 ` dormando
2014-06-11 7:26 ` dormando
2014-06-11 7:38 ` dormando
2014-06-11 12:41 ` Eric Dumazet
2014-06-11 13:12 ` Eric Dumazet
2014-06-12 1:55 ` dormando
2014-06-12 3:43 ` Eric Dumazet
2014-06-12 4:05 ` dormando
2014-06-22 19:07 ` dormando
2014-06-23 8:33 ` Eric Dumazet
2014-06-23 8:55 ` dormando
2014-06-23 16:57 ` Dmitry Vyukov
2014-06-24 17:05 ` [PATCH net] ipv4: fix dst race in sk_dst_get() Eric Dumazet
2014-06-26 0:42 ` David Miller
2014-06-11 13:38 ` [PATCH] ipv4: fix a race in ip4_datagram_release_cb() Kostya Serebryany
2014-06-29 0:25 ` dormando [this message]
2014-06-30 6:38 ` Eric Dumazet
2014-06-30 8:15 ` dormando
2014-06-30 8:30 ` Eric Dumazet
2014-07-08 1:41 ` dormando
2014-07-08 6:47 ` Eric Dumazet
2014-07-08 7:01 ` dormando
2014-07-16 21:03 ` dormando
2014-07-25 8:11 ` dormando
2014-06-30 8:26 ` [PATCH] ipv4: irq safe sk_dst_[re]set() and ipv4_sk_update_pmtu() fix Eric Dumazet
2014-07-01 6:43 ` David Miller
2014-06-11 22:39 ` [PATCH] ipv4: fix a race in ip4_datagram_release_cb() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406281724370.18954@dtop \
--to=dormando@rydia.net \
--cc=alexei.starovoitov@gmail.com \
--cc=brutus@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kcc@google.com \
--cc=larsbull@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=preobr@google.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox