From: Tina Johnson <tinajohnson.1234@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: tinajohnson.1234@gmail.com, chas@cmf.nrl.navy.mil,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] drivers: atm: eni: Add pci_dma_mapping_error() call
Date: Tue, 11 Nov 2014 19:52:30 +0530 (IST) [thread overview]
Message-ID: <alpine.DEB.2.02.1411111947230.6629@Miracleworker> (raw)
In-Reply-To: <20141110.153228.2187951801277440496.davem@davemloft.net>
On Mon, 10 Nov 2014, David Miller wrote:
> The 'trouble' label assumes that it is recovering and unwinding state
> when an error occurs after the DMA buffer is successfully mapped.
>
> It unconditionally does pci_unmap_single() if 'paddr' is non-zero
> which it might be in the error case depending upon how DMA errors
> are represented on a given platform.
Sorry for the trouble and thankyou for your very helpful comment. I
will send the revised patch.
prev parent reply other threads:[~2014-11-11 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 16:18 [PATCH] drivers: atm: eni: Add pci_dma_mapping_error() call Tina Johnson
2014-11-10 20:32 ` David Miller
2014-11-11 14:22 ` Tina Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1411111947230.6629@Miracleworker \
--to=tinajohnson.1234@gmail.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).