From: Julia Lawall <julia.lawall@lip6.fr>
To: Bas Peters <baspeters93@gmail.com>
Cc: isdn@linux-pingi.de, julia.lawall@lip6.fr, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix brace
Date: Sat, 7 Feb 2015 20:15:21 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1502072014420.2050@localhost6.localdomain6> (raw)
In-Reply-To: <1423335929-24926-8-git-send-email-baspeters93@gmail.com>
On Sat, 7 Feb 2015, Bas Peters wrote:
> This patch adds the \ that was accidentally deleted in patch 2. It also adds a brace after the else statement, which is required due to the fact that the if statement has braces.
You should fix the patch that was incorrect, rather than submitting a
patch that does something incorrect and then another patch to fix it. The
kernel should compile after every patch.
julia
>
> ---
> drivers/isdn/act2000/capi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c
> index 5d677e6..0043b3c 100644
> --- a/drivers/isdn/act2000/capi.c
> +++ b/drivers/isdn/act2000/capi.c
> @@ -113,8 +113,9 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr)
> m->hdr.cmd.cmd = c; \
> m->hdr.cmd.subcmd = s; \
> m->hdr.msgnum = actcapi_nextsmsg(card); \
> - } else
> + } else { \
> m = NULL; \
> + } \
> }
>
> #define ACTCAPI_CHKSKB if (!skb) { \
> --
> 2.1.0
>
>
prev parent reply other threads:[~2015-02-07 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 19:05 [PATCH V2 0/7] drivers: isdn: act2000: fix checkpatch errors Bas Peters
2015-02-07 19:05 ` [PATCH 1/7] drivers: isdn: act2000: act2000_isa.c: Fix " Bas Peters
2015-02-07 19:05 ` [PATCH 2/7] drivers: isdn: act2000: capi.c: fix " Bas Peters
2015-02-07 19:09 ` Sergei Shtylyov
2015-02-07 19:05 ` [PATCH 3/7] drivers: isdn: act2000: remove assignments of variables in if conditions Bas Peters
2015-02-07 19:05 ` [PATCH 4/7] drivers: isdn: act2000: module.c: remove NULL-initialization of static variable Bas Peters
2015-02-07 19:05 ` [PATCH 5/7] drivers: isdn: act2000: module.c: remove parenthesres around return values Bas Peters
2015-02-07 19:05 ` [PATCH 6/7] drivers: isdn: act2000: fix wrongly positioned brace Bas Peters
2015-02-07 19:05 ` [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix brace Bas Peters
2015-02-07 19:12 ` Sergei Shtylyov
2015-02-07 19:15 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1502072014420.2050@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=baspeters93@gmail.com \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox