Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

[Julia Lawall <julia.lawall@lip6.fr>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1419 bytes --]



On Wed, 10 Jun 2015, Fabian Frederick wrote:

> 
> 
> > On 10 June 2015 at 21:52 Joe Perches <joe@perches.com> wrote:
> >
> >
> > On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote:
> > > Use kernel.h macro definition.
> > >
> > > Thanks to Julia Lawall for Coccinelle scripting support.
> > []
> > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c
> > > b/drivers/net/wireless/ath/ath5k/phy.c
> > []
> > > @@ -1566,17 +1566,13 @@ static s16
> > >  ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
> > >  {
> > >     s16 sort[ATH5K_NF_CAL_HIST_MAX];
> > > -   s16 tmp;
> > >     int i, j;
> > > 
> > >     memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
> > >     for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
> > >             for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
> > > -                   if (sort[j] > sort[j - 1]) {
> > > -                           tmp = sort[j];
> > > -                           sort[j] = sort[j - 1];
> > > -                           sort[j - 1] = tmp;
> > > -                   }
> > > +                   if (sort[j] > sort[j - 1])
> > > +                           swap(sort[j], sort[j]);
> >
> > swap(a, a) doesn't look useful.
> Thanks a lot Joe, I'll fix this one :)

How did it come out like that?

julia

> 
> Regards,
> Fabian
> >
> >
>