Netdev List
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device
Date: Fri, 16 Oct 2015 17:58:41 -0500	[thread overview]
Message-ID: <alpine.DEB.2.02.1510161749490.25648@linux-builds1> (raw)
In-Reply-To: <1445028545-22599-1-git-send-email-andrew@lunn.ch>

On Fri, 16 Oct 2015, Andrew Lunn wrote:

> Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
> the bus' parent." broke finding PHY properties in the MAC device tree
> node. The parent device is now the MDIO bus, not the MAC. Use
> attached_dev towards the MAC device tree node.
> 
> Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> 
> Compile tested only.
> 
> Dinh, please could you test it and report back if it works or not.
>

This patch did not seem to fix the problem. The following code did seem to
fix the problem:

	if (!of_node && dev->parent->of_node)
-               of_node = dev->parent->of_node;
+       do {
+               of_node = dev->of_node;
+               dev = dev->parent;
+               i++;
+       } while (!of_node && dev);

BR,
Dinh

  reply	other threads:[~2015-10-16 23:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 20:49 [PATCH] net/phy: micrel: Follow attached_dev to get to the MAC device Andrew Lunn
2015-10-16 22:58 ` Dinh Nguyen [this message]
2015-10-16 23:50   ` Andrew Lunn
2015-10-17 14:21     ` Dinh Nguyen
2015-10-17 15:06       ` Dinh Nguyen
2015-10-17 15:38         ` Andrew Lunn
2015-10-17 17:38         ` Florian Fainelli
2015-10-17 20:45       ` Andrew Lunn
2015-10-18  4:15         ` Dinh Nguyen
2015-10-18  5:54           ` Dinh Nguyen
2015-10-16 23:32 ` Sergei Shtylyov
2015-10-16 23:54   ` Andrew Lunn
2015-10-17 18:46     ` Sergei Shtylyov
2015-10-17 19:23     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1510161749490.25648@linux-builds1 \
    --to=dinguyen@opensource.altera.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox