Re: SoCFPGA ethernet broken

Dinh Nguyen
2015-10-16T14:38:37Z

On Fri, 16 Oct 2015, Andrew Lunn wrote:

> > Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached
> > to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when
> > the call to ksz9021_config_init() is made both of_node and dev->parent->of_node
> > are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus
> > the skew values get programmed to the phy.
>
> Ah!
>
> You have the phy device tree parameters in the wrong place. These are
> phy paramters, so should really be in the phy node. But
> socfpga_cyclone5_socdk.dts has them in the MAC node.
>

Alright, let me see if I can rework the DTS.

> There is nothing in Documentation/devicetree/bindings/net/micrel.txt
> which says you are allowed to place them in the MAC node. Obviously
> the code did allow this, which is what has now broken.
>

I was following Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and
in this document I was following the autodetected PHY example. Did I mis-interpret
the example?

BR,
Dinh