From: Julia Lawall <julia.lawall@lip6.fr>
To: grundler@parisc-linux.org
Cc: netdev@vger.kernel.org
Subject: question about tulip/winbond-840.c
Date: Thu, 2 Jan 2014 15:24:49 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.10.1401021520280.2088@hadrien> (raw)
I don't know if you want to bother about this, because it is very old code
and is apparently not hurting anyone, but I don't see the point of the
call to pci_enable_device in the function w840_resume. The driver had a
call to pci_enable_device in its probe function, but it contains no call
to pci_disable_device, unlike some other tulip drivers. Perhaps the call
has a small functionality, but it seems like it can at least never return
a value other than 0, because the result of
atomic_inc_return(&dev->enable_cnt) in pci_enable_device_flags should
be greater than 1.
julia
next reply other threads:[~2014-01-02 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 14:24 Julia Lawall [this message]
2014-01-02 15:37 ` question about tulip/winbond-840.c Grant Grundler
2014-01-02 16:16 ` Julia Lawall
2014-01-02 16:53 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1401021520280.2088@hadrien \
--to=julia.lawall@lip6.fr \
--cc=grundler@parisc-linux.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox