[PATCH] ixp4xx_hss: Delete an unnecessary check before the function call "dma_pool_destroy"

SF Markus Elfring
2015-11-16T12:36:33Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 16 Nov 2015 13:30:37 +0100

The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/wan/ixp4xx_hss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index e7bbdb7..0d2593a 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c
@@ -1037,7 +1037,7 @@ static void destroy_hdlc_queues(struct port *port)
port->desc_tab = NULL;
}

- if (!ports_open && dma_pool) {
+ if (!ports_open) {
dma_pool_destroy(dma_pool);
dma_pool = NULL;
}
--
2.6.2