Re: [PATCH 3/3] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

SF Markus Elfring
2015-11-20T10:56:39Z

>> -out:
>> + batadv_tt_global_entry_free_ref(tt_global_entry);
>> +local_entry_free:
>> + batadv_tt_local_entry_free_ref(tt_local_entry);
>> +vlan_free:
>> batadv_softif_vlan_free_ref(vlan);
>> - if (tt_global_entry)
>> - batadv_tt_global_entry_free_ref(tt_global_entry);
>> - if (tt_local_entry)
>> - batadv_tt_local_entry_free_ref(tt_local_entry);
>> return ret;

> if you really want to make this codestyle change, I'd suggest you to go
> through the whole batman-adv code and apply the same change where needed.

Thanks for your interest in similar source code changes.

I would prefer general acceptance for this specific update suggestion
before I might invest further software development efforts for the
affected network module.

> It does not make sense to change the codestyle in one spot only.

I agree in the way that I would be nice if more places can still be improved.

> On top of that, by going through the batman-adv code you might agree
> that the current style is actually not a bad idea.

I got the impression that the current Linux coding style convention
disagrees around the affected jump label selection to some degree,
doesn't it?

Regards,
Markus