From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH] ethernet: micrel: use time_after_eq macro Date: Fri, 5 Jun 2015 17:45:50 +0200 (CEST) Message-ID: References: <1433514627-16845-1-git-send-email-antonio.murdaca@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, julia.lawall@lip6.fr, akpm@linux-foundation.org To: Antonio Murdaca Return-path: In-Reply-To: <1433514627-16845-1-git-send-email-antonio.murdaca@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 5 Jun 2015, Antonio Murdaca wrote: > use time_after_eq macro for time comparison > > Signed-off-by: Antonio Murdaca > --- > drivers/net/ethernet/micrel/ksz884x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c > index 48d2aec..9bce30c 100644 > --- a/drivers/net/ethernet/micrel/ksz884x.c > +++ b/drivers/net/ethernet/micrel/ksz884x.c > @@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr) > > /* This is used to verify Wake-on-LAN is working. */ > if (hw_priv->pme_wait) { > - if (hw_priv->pme_wait <= jiffies) { > + if (time_after_eq(jiffies, hw_priv->pme_wait)) { There is also time_is_before_eq_jiffies. julia > hw_clr_wol_pme_status(&hw_priv->hw); > hw_priv->pme_wait = 0; > } > -- > 2.4.2 > >