From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] macvtap: fix bugon.cocci warnings Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Michael S. Tsirkin" , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org To: Mike Rapoport Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:6749 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbcFHQPe (ORCPT ); Wed, 8 Jun 2016 12:15:34 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -796,8 +796,7 @@ static ssize_t macvtap_put_user(struct m ret = virtio_net_hdr_from_skb(skb, &vnet_hdr, macvtap_is_little_endian(q)); - if (ret) - BUG(); + BUG_ON(ret); if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter) != sizeof(vnet_hdr))