From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, davem@davemloft.net, preid@electromag.com.au, dinguyen@opensource.altera.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thloh85@gmail.com, cnphoon@altera.com, thloh@altera.com, kbuild-all@01.org To: thloh@altera.com Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Tien Hock Loh Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- This patch refers to the following code: url: https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T SE-PCS-support-to-dwmac-socfpga/20160621-164854 dwmac-socfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c @@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru dev_err(dev, "%s: ERROR: failed mapping tse control port\n", __func__); - return PTR_ERR(dwmac->pcs.sgmii_adapter_base); + return PTR_ERR(dwmac->pcs.tse_pcs_base); } } }