From: Thomas Gleixner <tglx@linutronix.de>
To: Manoil Claudiu <claudiu.manoil@freescale.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"David S. Miller" <davem@davemloft.net>,
Kevin Hao <haokexin@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag
Date: Mon, 21 Sep 2015 18:51:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1509211848510.5606@nanos> (raw)
In-Reply-To: <BY2PR0301MB072700F43F00CFC273FED1B59C460@BY2PR0301MB0727.namprd03.prod.outlook.com>
On Mon, 21 Sep 2015, Manoil Claudiu wrote:
> >The device is set as wakeup capable using proper wakeup API but the
> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source
> >which is incorrect.
> >
> >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
> >enable_irq_wake instead.
> >
>
> What would be the purpose of IRQF_NO_SUSPEND flag then? The flag is a
> friendlier API compared to calling enable_irq_wake(). For older kernels,
It's not an API, it's just a bandaid for lazy programmers.
> on PPC architectures, the flag did the job. When did this change? Since
> when using IRQF_NO_SUSPEND is a "misuse"?
It always was. Simply because IRQF_NO_SUSPEND has absolutely nothing
to do with wakeup interrupt sources. It's a flag which excludes the
interrupt from the suspend mechanism, but it does not flag it a wakeup
source.
Thanks,
tglx
next prev parent reply other threads:[~2015-09-21 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>
2015-09-21 15:47 ` [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-09-21 16:24 ` Manoil Claudiu
2015-09-21 16:38 ` Sudeep Holla
2015-09-21 16:51 ` Thomas Gleixner [this message]
2015-09-22 14:04 ` Manoil Claudiu
2015-09-22 15:09 ` Sudeep Holla
2015-09-23 21:20 ` Li Yang
2015-09-23 22:03 ` Thomas Gleixner
2015-09-24 21:17 ` Li Yang
2015-09-24 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1509211848510.5606@nanos \
--to=tglx@linutronix.de \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=haokexin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox