Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices

Thomas Gleixner
2016-02-24T10:56:49Z

On Mon, 22 Feb 2016, Christopher S. Hall wrote:
> +{
> + struct timekeeper *tk = &tk_core.timekeeper;
> + bool interp_forward;
> + u64 corr_raw, corr_real;
> + int ret;

Once more:

struct timekeeper *tk = &tk_core.timekeeper;
u64 corr_raw, corr_real;
bool interp_forward;
int ret;

Is way simpler to parse fast.

> {
> struct timekeeper *tk = &tk_core.timekeeper;
> @@ -929,6 +1046,12 @@ int get_device_system_crosststamp(int (*get_time_fn)
> ktime_t base_real;
> s64 nsec_raw;
> s64 nsec_real;
> + cycles_t cycles;
> + cycle_t now;
> + cycle_t interval_start;
> + unsigned int clock_was_set_seq;
> + u8 cs_was_changed_seq;
> + bool do_interp;

Single lines for same types .....

Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>