From: Thomas Gleixner <tglx@linutronix.de>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rt@linutronix.de
Subject: Re: [PATCH] net: mvneta: Add missing hotplug notifier transition
Date: Fri, 11 Mar 2016 11:48:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603111146310.3657@nanos> (raw)
In-Reply-To: <8737rx2tqw.fsf@free-electrons.com>
Gregory,
On Fri, 11 Mar 2016, Gregory CLEMENT wrote:
> On ven., mars 11 2016, Anna-Maria Gleixner <anna-maria@linutronix.de> wrote:
>
> > The mvneta_percpu_notifier() hotplug callback lacks handling of the
> > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the
> > driver is not well configured on the CPU.
> >
> > Add handling for CPU_DOWN_FAILED[_FROZEN] hotplug notifier transition
> > to setup the driver.
>
> I agree that we need to handle this case, however reusing CPU_ONLINE
> case for it seems too much.
Why is that too much? If it does the job, then it's definitely preferrable
over an extra case for a non hotpath error handling operation.
Thanks,
tglx
next prev parent reply other threads:[~2016-03-11 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 9:10 [PATCH] net: mvneta: Add missing hotplug notifier transition Anna-Maria Gleixner
2016-03-11 10:28 ` Gregory CLEMENT
2016-03-11 10:48 ` Thomas Gleixner [this message]
2016-03-14 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1603111146310.3657@nanos \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox