From: Thomas Gleixner <tglx@linutronix.de>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>,
Richard Cochran <richardcochran@gmail.com>,
Yann E MORIN <yann.morin.1998@free.fr>,
Josh Triplett <josh@joshtriplett.org>,
netdev@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ptp_clock: allow for it to be optional
Date: Thu, 20 Oct 2016 19:58:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610201958110.4938@nanos> (raw)
In-Reply-To: <alpine.LFD.2.20.1610201338330.25105@knanqh.ubzr>
On Thu, 20 Oct 2016, Nicolas Pitre wrote:
> On Thu, 20 Oct 2016, Thomas Gleixner wrote:
>
> > On Wed, 19 Oct 2016, Nicolas Pitre wrote:
> > > The pch_gbe driver is a bit special as it relies on extra code in
> > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
> > > drivers/ptp/ even if PTP_1588_CLOCK is unselected.
> >
> > The above paragraph looks like a leftover of the previous patch set.
>
> Not really. Without the change to drivers/Makefile, drivers/ptp/ is not
> visited when CONFIG_PTP_1588_CLOCK=n. If you then have CONFIG_PCH_GBE=y
> you end up with:
>
> drivers/built-in.o: In function `pch_gbe_ioctl':
> pch_gbe_main.c:(.text+0x28c914): undefined reference to `pch_ch_control_write'
>
> Hence the above paragraph.
Indeed. I misread that.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-20 17:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 23:42 [PATCH 0/4] make POSIX timers optional with some Kconfig help Nicolas Pitre
2016-10-19 23:42 ` [PATCH 1/4] kconfig: introduce the "imply" keyword Nicolas Pitre
2016-10-20 6:53 ` Masahiro Yamada
2016-10-20 14:52 ` Edward Cree
2016-10-20 15:38 ` Josh Triplett
2016-10-20 17:04 ` Nicolas Pitre
2016-10-20 17:41 ` Edward Cree
2016-10-20 18:29 ` Nicolas Pitre
2016-10-20 19:09 ` Edward Cree
2016-10-20 20:10 ` Nicolas Pitre
2016-10-21 3:24 ` Nicolas Pitre
2016-10-19 23:42 ` [PATCH 2/4] kconfig: re-generate *.c_shipped files after previous change Nicolas Pitre
2016-10-19 23:42 ` [PATCH 3/4] ptp_clock: allow for it to be optional Nicolas Pitre
2016-10-20 9:50 ` Thomas Gleixner
2016-10-20 17:47 ` Nicolas Pitre
2016-10-20 17:58 ` Thomas Gleixner [this message]
2016-10-20 14:06 ` Richard Cochran
2016-10-20 15:38 ` Josh Triplett
2016-10-20 16:44 ` Nicolas Pitre
2016-10-19 23:42 ` [PATCH 4/4] posix-timers: make it configurable Nicolas Pitre
2016-10-20 14:02 ` Richard Cochran
2016-10-20 16:41 ` Nicolas Pitre
2016-10-20 9:46 ` [PATCH 0/4] make POSIX timers optional with some Kconfig help Thomas Gleixner
2016-10-20 18:35 ` Nicolas Pitre
2016-10-20 18:51 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610201958110.4938@nanos \
--to=tglx@linutronix.de \
--cc=john.stultz@linaro.org \
--cc=josh@joshtriplett.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richardcochran@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).