From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [patch net-next] stmmac: indent an if statement Date: Thu, 12 Jan 2017 20:46:05 +0100 (CET) Message-ID: References: <20170112184631.GA12157@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Giuseppe Cavallaro , jpinto , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: In-Reply-To: <20170112184631.GA12157@mwanda> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 12 Jan 2017, Dan Carpenter wrote: > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index ac32f9e..4daa8a3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -191,7 +191,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > for_each_child_of_node(np, plat->mdio_node) { > if (of_device_is_compatible(plat->mdio_node, > "snps,dwmac-mdio")) > - break; > + break; If there is a break, there is probably also a need for an of_node_put? julia > } > } > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >