From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [patch net-next] stmmac: indent an if statement Date: Mon, 16 Jan 2017 23:10:32 +0100 (CET) Message-ID: References: <20170112184631.GA12157@mwanda> <20170115.221438.1956356112755181222.davem@davemloft.net> <20170116091924.GA4104@mwanda> <20170116093954.GB4104@mwanda> <20170116215615.GG4104@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: David Miller , peppe.cavallaro@st.com, Joao.Pinto@synopsys.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: In-Reply-To: <20170116215615.GG4104@mwanda> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 17 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > > > From: Dan Carpenter > > > > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > > > > > > > The break statement should be indented one more tab. > > > > > > > > > > > > Signed-off-by: Dan Carpenter > > > > > > > > > > Applied, but like Julia I think we might have a missing of_node_put() > > > > > here. > > > > > > > > Of course, sorry for dropping the ball on this. I'll send a patch for > > > > that. > > > > > > > > > > Actually, I've looked at it some more and I think this function is OK. > > > We're supposed to do an of_node_put() later... I can't find where that > > > happens, but presumably that's because I don't know stmmac well. This > > > code here, though, is fine. > > > > Why do you think it is fine? Does anyone in the calling context know > > which child would have caused the break? > > Yeah. It's saved in plat->mdio_node and we expect to be holding on > either path through the function. > > (It would be better if one of the stmmac people were responding here > insead of a random fix the indenting weenie like myself.) OK, I agree that there should not be an of_node_put with the break. Perhaps there should be an of_node_put on plat->mdio_node in stmmac_remove_config_dt, like there is an of_node_put on plat->phy_node. But it would certainly be helpful to hear from someone who knows the code better. julia